Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752849AbbG2HtL (ORCPT ); Wed, 29 Jul 2015 03:49:11 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:34768 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752438AbbG2HtH (ORCPT ); Wed, 29 Jul 2015 03:49:07 -0400 MIME-Version: 1.0 In-Reply-To: <20150729072156.GO16722@phenom.ffwll.local> References: <1438152892-11256-1-git-send-email-jianwei.wang.chn@gmail.com> <20150729072156.GO16722@phenom.ffwll.local> From: Jianwei Wang Date: Wed, 29 Jul 2015 15:48:47 +0800 Message-ID: Subject: Re: [PATCH v13 0/6] drm/layerscape: Add Freescale DCU DRM driver To: Jianwei Wang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, airlied@linux.ie, =?UTF-8?B?5aea5pm65oOF?= , scottwood@freescale.com, Thierry Reding , Shawn Guo Cc: Daniel Vetter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7151 Lines: 182 On Wed, Jul 29, 2015 at 3:21 PM, Daniel Vetter wrote: > On Wed, Jul 29, 2015 at 02:54:46PM +0800, Jianwei Wang wrote: >> Changed in v13 >> -set regmap_config.cache_type to REGCACHE_RBTREE >> -add call drm_modeset_lock_all before drm_mode_config_reset > > This was a bug in one of my recently merged patches, please don't call > drm_modeset_lock_all before config_reset. Instead please test "drm: Fixup > locking WARNINGs in drm_mode_config_reset" which should address this > problem too. > I have test that patch, It's okay. I'll remove drm_modeset_lock_all. Thanks Jianwei > Thanks, Daniel > >> -adjust patch order for creating pull request >> >> Changed in v12 >> >> -Add one patch for MAINTAINER entry for drm/layerscape >> Adviced by Daniel Vetter >> -Add #include >> >> Changed in V11 >> -set regmap_config.cache_type to REGCACHE_FLAT >> Advanced by Alexander Stein >> >> Changed in V10 >> -adjust commit log, remove meaningless statement >> -cleanup code for it's format and style. >> -remove platform related code out, including of tcon(vf610) and scfg(ls1021a) >> -remove useless sentences: encoder->crtc = crtc; and connector->encoder = encoder; and so on >> -add vendor prefix for panel pandle >> -make a DCU_CTRLDESCLN(x, y) to avoid high repetition >> -introduce per-SoC capability structure to avoid check on the OF node's compatible string >> -Implement some functions: crtc enable and disable, enable and disable VBLANK, plane atomic_disable and atomic_enable -atomic_check and so on >> -move DCU config sentence to the right place >> -move get resources functions to ->probe() >> -move fsl,dcu.txt to video/ folder >> -add big-endian describe >> All advaced by Thierry Reding >> >> Changed in V9 >> >> put node after calling of_drm_find_panel >> split clk_prepare_enable() to clk_prepare() and clk_enable(), just call clk_prepare once, and check return value >> check regmap_write/regmap_read return return value >> remove useless ".owner = THIS_MODULE," >> All advanced by Mark Yao >> >> Changed in V8 >> >> - Remove useless code >> #define DRIVER_NAME "fsl-dcu-drm" >> MODULE_ALIAS("platform:fsl-dcu-drm"); >> Adviced by Paul Bolle >> >> Changed in V7 >> >> - Remove redundant functions and replace deprecated hook >> Adviced by Daniel Vetter >> - Replace drm_platform_init with drm_dev_alloc/register >> Adviced by Daniel Vetter >> >> Changed in V6 >> >> - Add NEC nl4827hc19_05b panel to panel-simple.c >> Adviced by Mark Yao >> - Add DRIVER_ATOMIC for driver_features >> Adviced by Mark Yao >> - check fsl_dev if it's NULL at PM suspend/resume >> Adviced by Mark Yao >> >> Changed in V5 >> >> - Update commit message >> - Add layer registers initialization >> - Remove unused functions >> - Rename driver folder >> Adviced by Stefan Agner >> - Move pixel clock control functions to fsl_dcu_drm_drv.c >> - remove redundant enable the clock implicitly using regmap >> - Add maintainer message >> >> Changed in V4: >> >> -This version doesn't have functionality changed >> Just a minor adjustment. >> >> Changed in V3: >> >> - Test driver on Vybrid board and add compatible string >> - Remove unused functions >> - set default crtc for encoder >> - replace legacy functions with atomic help functions >> Adviced by Daniel Vetter >> - Set the unique name of the DRM device >> - Implement irq handle function for vblank interrupt >> >> Changed in v2: >> - Add atomic support >> Adviced by Daniel Vetter >> - Modify bindings file >> - Rename node for compatibility >> - Move platform related code out for compatibility >> Adviced by Stefan Agner >> >> This patch add support for Two Dimensional Animation and Compositing >> Engine (2D-ACE) on the Freescale SoCs. >> >> 2D-ACE is a Freescale display controller. 2D-ACE describes >> the functionality of the module extremely well its name is a value >> that cannot be used as a token in programming languages. >> Instead the valid token "DCU" is used to tag the register names and >> function names. >> >> The Display Controller Unit (DCU) module is a system master that >> fetches graphics stored in internal or external memory and displays >> them on a TFT LCD panel. A wide range of panel sizes is supported >> and the timing of the interface signals is highly configurable. >> Graphics are read directly from memory and then blended in real-time, >> which allows for dynamic content creation with minimal CPU >> intervention. >> >> The features: >> (1) Full RGB888 output to TFT LCD panel. >> (2) Blending of each pixel using up to 4 source layers >> dependent >> on size of panel. >> (3) Each graphic layer can be placed with one pixel resolution >> in either axis. >> (4) Each graphic layer support RGB565 and RGB888 direct colors >> without alpha channel and BGRA8888 BGRA4444 ARGB1555 direct >> colors >> with an alpha channel and YUV422 format. >> (5) Each graphic layer support alpha blending with 8-bit >> resolution. >> >> .../devicetree/bindings/video/fsl,dcu.txt | 22 ++ >> drivers/gpu/drm/Kconfig | 2 + >> drivers/gpu/drm/Makefile | 1 + >> drivers/gpu/drm/fsl-dcu/Kconfig | 18 + >> drivers/gpu/drm/fsl-dcu/Makefile | 7 + >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 208 +++++++++++ >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.h | 19 + >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 404 +++++++++++++++++++++ >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h | 197 ++++++++++ >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_fbdev.c | 23 ++ >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 45 +++ >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_output.h | 33 ++ >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 261 +++++++++++++ >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.h | 17 + >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 182 ++++++++++ >> 15 files changed, 1439 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/video/fsl,dcu.txt >> create mode 100644 drivers/gpu/drm/fsl-dcu/Kconfig >> create mode 100644 drivers/gpu/drm/fsl-dcu/Makefile >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.h >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_fbdev.c >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_output.h >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.h >> create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c >> > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/