Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753542AbbG2INo (ORCPT ); Wed, 29 Jul 2015 04:13:44 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:27949 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbbG2INl (ORCPT ); Wed, 29 Jul 2015 04:13:41 -0400 Date: Wed, 29 Jul 2015 11:13:25 +0300 From: Dan Carpenter To: Shraddha Barke Cc: Johnny Kim , Rachel Kim , Dean Lee , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Chris Park , devel@driverdev.osuosl.org Subject: Re: [PATCH] Staging : wilc1000: Remove unnecessary parentheses Message-ID: <20150729081325.GG5180@mwanda> References: <1438147670-7590-1-git-send-email-shraddha.6596@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438147670-7590-1-git-send-email-shraddha.6596@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 15 The original code is fine... I probably would write it the way you suggest, but I can also see why people would write it the other way. This isn't an official CodingStyle rule so I feel like the author gets to choose. Part of the reason for CodingStyle is so that we don't run into madness of changing every single thing all the time. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/