Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751315AbbG2KBb (ORCPT ); Wed, 29 Jul 2015 06:01:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54297 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbbG2KB3 (ORCPT ); Wed, 29 Jul 2015 06:01:29 -0400 Date: Wed, 29 Jul 2015 13:01:26 +0300 From: "Michael S. Tsirkin" To: Shannon Zhao Cc: Peter Maydell , G Gregory , "virtualization@lists.linux-foundation.org" , lkml - Kernel Mailing List , Alex =?iso-8859-1?Q?Benn=E9e?= Subject: Re: [PATCH] virtio_mmio: add ACPI probing Message-ID: <20150729125213-mutt-send-email-mst@redhat.com> References: <1438076642-12080-1-git-send-email-graeme.gregory@linaro.org> <20150728130604-mutt-send-email-mst@redhat.com> <20150728132113-mutt-send-email-mst@redhat.com> <55B833FF.20107@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55B833FF.20107@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2100 Lines: 49 On Wed, Jul 29, 2015 at 10:01:35AM +0800, Shannon Zhao wrote: > > > On 2015/7/29 5:10, Peter Maydell wrote: > > On 28 July 2015 at 21:28, G Gregory wrote: > >> > On 28 July 2015 at 21:12, Peter Maydell wrote: > >>> >> Mmm. I'm not terribly happy about stuff being in QEMU before the > >>> >> ACPI spec for it has been finalised. We should not be picking > >>> >> stuff randomly on the fly... > >>> >> > >>> >> If we want to fix the ACPI IDs QEMU is using for 2.4 then we > >>> >> really need to do that now (ie within the next day or two). > >>> >> > >> > It is upto the owner of the QEMU prefix to allocate numbers. This is > >> > not an issue for ACPI spec at all. > > I mean "the specification for how this device should be advertised > > in an ACPI table". I don't care whether that's an official ACPI > > consortium thing or something less official. The table is > > constructed by QEMU and read by the kernel (and possibly > > also by UEFI?), so everybody needs to agree on what the > > string is... > > I agree with Peter. Maybe we should record these IDs at some place. Right. And it should apply even if you keep using LNRO. Pls create docs/specs/acpi_ids.txt and list them there. For simplicity, I'd just replace LNRO with QEMU. > Since QEMU is owner of this device and we register QEMU in ASWG, the > official ID can be assigned by QEMU and the ID could(or should) be > "QEMUXXXX". But what's the exact ID for this virtio-mmio? That's what we > need to agree on and record. So far we only had PVPANIC with ACPI ID QEMU0001. > P.S. I don't see "QEMU" in the list of approved Vendor IDs for ACPI. > http://www.uefi.org/sites/default/files/resources/PNPID_List.pdf > http://www.uefi.org/sites/default/files/resources/ACPIID_List.pdf Should appear there any day now. > -- > Shannon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/