Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262AbbG2LUe (ORCPT ); Wed, 29 Jul 2015 07:20:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41800 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753130AbbG2LUb (ORCPT ); Wed, 29 Jul 2015 07:20:31 -0400 Date: Wed, 29 Jul 2015 13:20:29 +0200 From: Jiri Olsa To: Kan Liang Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org, ak@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC V6 5/6] perf,tool: per-event callgraph support Message-ID: <20150729112029.GB9606@krava.brq.redhat.com> References: <1437999699-19632-1-git-send-email-kan.liang@intel.com> <1437999699-19632-6-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437999699-19632-6-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 25 On Mon, Jul 27, 2015 at 08:21:38AM -0400, Kan Liang wrote: SNIP > struct parse_events_term { > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index f542750..16af73b 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -184,6 +184,8 @@ name { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_NAME); } > period { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_SAMPLE_PERIOD); } > branch_type { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_BRANCH_SAMPLE_TYPE); } > time { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_TIME); } > +callgraph { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_CALLGRAPH); } > +stack_size { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_TIME); } hum, maybe we could be consistent with the command line --call-graph option and use 'call-graph' and 'stack-size' jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/