Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752094AbbG2L2E (ORCPT ); Wed, 29 Jul 2015 07:28:04 -0400 Received: from smtp.citrix.com ([66.165.176.89]:23754 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbbG2L2B (ORCPT ); Wed, 29 Jul 2015 07:28:01 -0400 X-IronPort-AV: E=Sophos;i="5.15,570,1432598400"; d="scan'208";a="285582635" Message-ID: <55B8B88B.2070400@citrix.com> Date: Wed, 29 Jul 2015 12:27:07 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "Chris (Christopher) Brand" , "xen-devel@lists.xenproject.org" CC: "linux-fbdev@vger.kernel.org" , "H. Peter Anvin" , Jiri Slaby , Boris Ostrovsky , Russell King , "linux-scsi@vger.kernel.org" , Tomi Valkeinen , "x86@kernel.org" , Ingo Molnar , "linux-input@vger.kernel.org" , Jean-Christophe Plagniol-Villard , "ian.campbell@citrix.com" , "stefano.stabellini@eu.citrix.com" , "James E.J. Bottomley" , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Juergen Gross , "Wei Liu" , Greg Kroah-Hartman , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , David Vrabel , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <1438095769-2560-5-git-send-email-julien.grall@citrix.com> <4EE5B48738DDED408878C97C8E050A8B1D7DDBB5@SJEXCHMB05.corp.ad.broadcom.com> In-Reply-To: <4EE5B48738DDED408878C97C8E050A8B1D7DDBB5@SJEXCHMB05.corp.ad.broadcom.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1043 Lines: 32 Hi Chris, On 28/07/15 20:39, Chris (Christopher) Brand wrote: >> Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, >> I suspect this is because the first support for Xen was for PV. This brough some > Typo : "brought" > Perhaps "resulted in" would be better ? > >> misimplementation of helpers on ARM and make the developper confused the expected behavior. > Typo: "developer". > I'd also suggest "...and confused developers about the...". > > [...] > >> For clarity and avoid new confusion, replace any reference of mfn into gnf in any helpers used by PV drivers. > Typo : "gfn" > I'd suggest "...replace any reference to mfn with gfn..." > > [...] Thanks for telling me the typoes. I will fix it in the next version of this series. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/