Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752088AbbG2LiZ (ORCPT ); Wed, 29 Jul 2015 07:38:25 -0400 Received: from smtp.citrix.com ([66.165.176.89]:17140 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbbG2LiX (ORCPT ); Wed, 29 Jul 2015 07:38:23 -0400 X-IronPort-AV: E=Sophos;i="5.15,570,1432598400"; d="scan'208";a="285584749" Message-ID: <55B8BB29.3000202@citrix.com> Date: Wed, 29 Jul 2015 12:38:17 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Julien Grall , Wei Liu CC: , "H. Peter Anvin" , "Thomas Gleixner" , , "Russell King" , , , Tomi Valkeinen , Jiri Slaby , , "Jean-Christophe Plagniol-Villard" , , , "James E.J. Bottomley" , Boris Ostrovsky , Ingo Molnar , , Juergen Gross , "Greg Kroah-Hartman" , Dmitry Torokhov , , , , =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <1438095769-2560-5-git-send-email-julien.grall@citrix.com> <20150729101323.GW5111@zion.uk.xensource.com> <55B8BA9A.8000502@citrix.com> In-Reply-To: <55B8BA9A.8000502@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1860 Lines: 48 On 29/07/15 12:35, Julien Grall wrote: > Hi Wei, > > On 29/07/15 11:13, Wei Liu wrote: >> On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: >> [...] >>> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c >>> index 7d50711..3b7b7c3 100644 >>> --- a/drivers/net/xen-netback/netback.c >>> +++ b/drivers/net/xen-netback/netback.c >>> @@ -314,7 +314,7 @@ static void xenvif_gop_frag_copy(struct xenvif_queue *queue, struct sk_buff *skb >>> } else { >>> copy_gop->source.domid = DOMID_SELF; >>> copy_gop->source.u.gmfn = >>> - virt_to_mfn(page_address(page)); >>> + virt_to_gfn(page_address(page)); >>> } >>> copy_gop->source.offset = offset; >>> >>> @@ -1284,7 +1284,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, >>> queue->tx_copy_ops[*copy_ops].source.offset = txreq.offset; >>> >>> queue->tx_copy_ops[*copy_ops].dest.u.gmfn = >>> - virt_to_mfn(skb->data); >>> + virt_to_gfn(skb->data); >>> queue->tx_copy_ops[*copy_ops].dest.domid = DOMID_SELF; >>> queue->tx_copy_ops[*copy_ops].dest.offset = >>> offset_in_page(skb->data); >> >> Reviewed-by: Wei Liu >> >> One possible improvement is to change gmfn in copy_gop to gfn as well. >> But that's outside of netback code. > > The structure gnttab_copy is part of the hypervisor interface. Is it > fine to differ on the naming between Xen and Linux? > > Or maybe we could do the change in the public headers in Xen repo too. > Is it fine to do field renaming in public headers? I think this series should not alter than Xen API. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/