Date: Wed, 29 Jul 2015 14:52:20 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: kan.liang@intel.com
Cc: a.p.zijlstra@chello.nl, acme@kernel.org, luto@kernel.org, mingo@redhat.com,
        eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
        adrian.hunter@intel.com, jolsa@kernel.org, namhyung@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%
 in report -D
Message-ID: <20150729125220.GG9606@krava.brq.redhat.com>
References: <1438082975-47730-1-git-send-email-kan.liang@intel.com>
 <1438082975-47730-4-git-send-email-kan.liang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438082975-47730-4-git-send-email-kan.liang@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1382
Lines: 35

On Tue, Jul 28, 2015 at 07:29:33AM -0400, kan.liang@intel.com wrote:

SNIP

> -static void dump_sample(struct perf_evsel *evsel, union perf_event *event,
> +static void dump_sample(struct perf_session *session, struct perf_evlist *evlist,
> +			struct perf_evsel *evsel, union perf_event *event,
>  			struct perf_sample *sample)
>  {
>  	u64 sample_type;
> @@ -938,7 +963,7 @@ static void dump_sample(struct perf_evsel *evsel, union perf_event *event,
>  		printf("... transaction: %" PRIx64 "\n", sample->transaction);
>  
>  	if (sample_type & PERF_SAMPLE_READ)
> -		sample_read__printf(sample, evsel->attr.read_format);
> +		sample_read__printf(session, evlist, sample, evsel->attr.read_format);
>  }
>  
>  static struct machine *machines__find_for_cpumode(struct machines *machines,
> @@ -1036,12 +1061,13 @@ static int
>  					    &sample->read.one, machine);
>  }
>  
> -static int machines__deliver_event(struct machines *machines,
> +static int machines__deliver_event(struct perf_session *session,
>  				   struct perf_evlist *evlist,

you can cut the evlist argument as well, because it's always from session->evlist

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/