Date: Wed, 29 Jul 2015 15:07:04 +0200 (CEST)
From: Jiri Kosina <jkosina@suse.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, sre@kernel.org,
        linux-pm@vger.kernel.org, "H.J. Lu" <hjl.tools@gmail.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH] HID: hid-input: Fix accessing freed memory during driver
 unbind
In-Reply-To: <1438042590-17719-1-git-send-email-k.kozlowski@samsung.com>
Message-ID: <alpine.LNX.2.00.1507291506500.925@pobox.suse.cz>
References: <1438042590-17719-1-git-send-email-k.kozlowski@samsung.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1083
Lines: 28

On Tue, 28 Jul 2015, Krzysztof Kozlowski wrote:

> During unbinding the driver was dereferencing a pointer to memory
> already freed by power_supply_unregister().
> 
> Driver was freeing its internal description of battery through pointers
> stored in power_supply structure. However, because the core owns the
> power supply instance, after calling power_supply_unregister() the
> driver cannot access these members.
> 
> Fix this by using resource-managed allocations so internal data will be
> freed by pointers stored in resource-managed core.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reported-by: H.J. Lu <hjl.tools@gmail.com>
> Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core")
> Cc: <stable@vger.kernel.org>

Applied to for-4.2/upstream-fixes, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/