Date: Wed, 29 Jul 2015 15:22:57 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: kan.liang@intel.com
Cc: a.p.zijlstra@chello.nl, acme@kernel.org, luto@kernel.org, mingo@redhat.com,
        eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
        adrian.hunter@intel.com, jolsa@kernel.org, namhyung@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 5/5] perf,tools: Show freq/CPU%/CORE_BUSY% in perf
 report --stdio
Message-ID: <20150729132256.GK9606@krava.brq.redhat.com>
References: <1438082975-47730-1-git-send-email-kan.liang@intel.com>
 <1438082975-47730-6-git-send-email-kan.liang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438082975-47730-6-git-send-email-kan.liang@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1111
Lines: 41

On Tue, Jul 28, 2015 at 07:29:35AM -0400, kan.liang@intel.com wrote:

SNIP

>  #undef DIM
> diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
> index b98ce51..467ecc4 100644
> --- a/tools/perf/util/symbol.h
> +++ b/tools/perf/util/symbol.h
> @@ -80,6 +80,14 @@ static inline size_t symbol__size(const struct symbol *sym)
>  struct strlist;
>  struct intlist;
>  
> +enum freq_perf_type_index {
> +	DISPLAY_FREQ		= 0,
> +	DISPLAY_CPU_UTIL,
> +	DISPLAY_CORE_BUSY,
> +
> +	DISPLAY_MAX
> +};
> +
>  struct symbol_conf {
>  	unsigned short	priv_size;
>  	unsigned short	nr_events;
> @@ -106,7 +114,9 @@ struct symbol_conf {
>  			filter_relative,
>  			show_hist_headers,
>  			branch_callstack,
> -			has_filter;
> +			has_filter,
> +			show_freq_perf,
> +			freq_perf_type[DISPLAY_MAX];

IMO bitmask of 'enum freq_perf_type_index' would be better

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/