Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753650AbbG2OCJ (ORCPT ); Wed, 29 Jul 2015 10:02:09 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:38594 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753399AbbG2OCG (ORCPT ); Wed, 29 Jul 2015 10:02:06 -0400 Message-ID: <55B8DCD8.9050404@linaro.org> Date: Wed, 29 Jul 2015 15:02:00 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , linux-arm-msm@vger.kernel.org CC: agross@codeaurora.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/7] ARM: dts: apq8064-ifc6410: add heart-beat led support. References: <1438087956-17307-1-git-send-email-srinivas.kandagatla@linaro.org> <1438088040-17437-1-git-send-email-srinivas.kandagatla@linaro.org> <55B7BDB8.7090103@suse.de> In-Reply-To: <55B7BDB8.7090103@suse.de> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 55 On 28/07/15 18:36, Andreas F?rber wrote: > Am 28.07.2015 um 14:54 schrieb Srinivas Kandagatla: >> This patch adds heart-beat led support on IFC6410. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> index df560cf..1fc2ea5 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> @@ -207,6 +207,19 @@ >> status = "okay"; >> }; >> >> + leds { >> + compatible = "gpio-leds"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <¬ify_led>; >> + >> + led@1 { >> + label = "apq8064:green:user1"; >> + gpios = <&pm8921_gpio 18 GPIO_ACTIVE_HIGH>; >> + linux,default-trigger = "heartbeat"; > > Can we please drop the heartbeat default? While that's nice as proof of > concept, it's annoying to deliver it that way in Linux distros. Users > can enable that trigger with a simple boot script writing to /sys. > Thanks for the input, I will change to be none, Let the users decide the trigger. thanks, srini > Thanks, > Andreas > >> + default-state = "on"; >> + }; >> + }; >> + >> qcom,ssbi@500000 { >> pmicintc: pmic@0 { >> pm8921_gpio: gpio@150 { > [snip] > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/