Date: Wed, 29 Jul 2015 11:20:23 -0400
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
        Daniel Vetter <daniel.vetter@intel.com>,
        intel-gfx@lists.freedesktop.org, Todd Broch <tbroch@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: hide errors when probing for a
 reverse display port
Message-ID: <20150729152022.GC2743@mail.corp.redhat.com>
References: <1438099409-25456-1-git-send-email-benjamin.tissoires@redhat.com>
 <1438099409-25456-3-git-send-email-benjamin.tissoires@redhat.com>
 <20150728161831.GF16528@nuc-i3427.alporthouse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150728161831.GF16528@nuc-i3427.alporthouse.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1379
Lines: 34

On Jul 28 2015 or thereabouts, Chris Wilson wrote:
> On Tue, Jul 28, 2015 at 12:03:28PM -0400, Benjamin Tissoires wrote:
> > We check the polarity of the attached dp, so it is normal to fail.
> > Do not send errors to the users.
> 
> if (probe) DRM_DEBUG else DRM_ERROR is fairly offensive.
> 
> It strikes me that you could make each of these functions report the
> failure to the caller (have the caller even do so error handling!) and
> as part of that have the caller report an error and so demote all of
> these to DRM_DEBUG_KMS().

Yes, sorry for that. I will change it to return an actual error code and
the error string if I still need to use these functions given Sivakumar
ideas. 

> 
> Who knows, actually doing some error handling may make monitor training
> more reliable! Or we may even get carried away and report the failure
> all the way back to userspace.

That would be a very good improvement indeed. But I can already tell you
that I will not do it by myself, I already have too much on my plate.
I'll do my share for this feature, but don't count on me for the whole
error handling rewrite :)

Cheers,
Benjamin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/