Subject: Re: [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
References: <1438109533-28694-1-git-send-email-rjui@broadcom.com>
 <33449873.RA3z6vhrMA@wuerfel>
CC: Olof Johansson <olof@lixom.net>, Bjorn Helgaas <bhelgaas@google.com>,
        Hauke Mehrtens <hauke@hauke-m.de>, <linux-pci@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <arm@kernel.org>,
        <bcm-kernel-feedback-list@broadcom.com>
From: Ray Jui <rjui@broadcom.com>
Message-ID: <55B8FC7E.50900@broadcom.com>
Date: Wed, 29 Jul 2015 09:17:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <33449873.RA3z6vhrMA@wuerfel>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 990
Lines: 35


On 7/29/2015 7:30 AM, Arnd Bergmann wrote:
> On Tuesday 28 July 2015 11:52:13 Ray Jui wrote:
>>  config PCIE_IPROC_BCMA
>>         bool "Broadcom iProc PCIe BCMA bus driver"
>> -       depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>> +       depends on ARCH_BCM_IPROC && ARM
>>         select PCIE_IPROC
>>         select BCMA
>>         select PCI_DOMAINS
>>
> 
> How about this:
> 
> 	depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
> 
> That would leave the compile test present for non-iproc
> ARM platforms while preventing ARM64 and MIPS builds with
> ARCH_BCM_IPROC set.
> 
> 	Arnd
> 

That is indeed better. Broader compile test coverage is always good.
I'll submit another patch with the above suggested change.

Thanks,

Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/