Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247AbbG2SDS (ORCPT ); Wed, 29 Jul 2015 14:03:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35193 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbbG2SDR (ORCPT ); Wed, 29 Jul 2015 14:03:17 -0400 Date: Wed, 29 Jul 2015 21:03:14 +0300 From: "Michael S. Tsirkin" To: Peter Maydell Cc: G Gregory , "virtualization@lists.linux-foundation.org" , lkml - Kernel Mailing List , Shannon Zhao , Alex =?iso-8859-1?Q?Benn=E9e?= Subject: Re: [PATCH] virtio_mmio: add ACPI probing Message-ID: <20150729210114-mutt-send-email-mst@redhat.com> References: <1438076642-12080-1-git-send-email-graeme.gregory@linaro.org> <20150728130604-mutt-send-email-mst@redhat.com> <20150728132113-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1854 Lines: 50 On Wed, Jul 29, 2015 at 06:52:29PM +0100, Peter Maydell wrote: > On 28 July 2015 at 11:33, G Gregory wrote: > > We assigned LNRO in ASWG to avoid collisions with our prototypes/real > > platforms so it makes sense to me to switch to QEMUXXXX. > > So just to check, if we switch virtio-mmio from an LNRO0005 ID > to a QEMUxxxx ID we aren't going to break any existing widely > shipped or deployed code, right? > > If we can change the ID without breaking anything significant > then I think the QEMU ID makes more sense; but it doesn't > really gain us much beyond tidiness. > > PS: https://www.kernel.org/doc/Documentation/arm64/arm-acpi.txt > uses virtio-mmio and LNRO0005 as its code example, so if > we change this then it might be nice to update the docs > as a followup. > > thanks > -- PMM So this is the proposed patch. I agree it's merely about tidyness. Pls ack or nack - we need to decide before 2.4 is out. --> arm: change vendor ID for virtio-mmio Signed-off-by: Michael S. Tsirkin --- diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index f365140..d10bd69 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -145,7 +145,7 @@ static void acpi_dsdt_add_virtio(Aml *scope, for (i = 0; i < num; i++) { Aml *dev = aml_device("VR%02u", i); - aml_append(dev, aml_name_decl("_HID", aml_string("LNRO0005"))); + aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0005"))); aml_append(dev, aml_name_decl("_UID", aml_int(i))); Aml *crs = aml_resource_template(); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/