Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753600AbbG2Slf (ORCPT ); Wed, 29 Jul 2015 14:41:35 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45548 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbbG2Slc (ORCPT ); Wed, 29 Jul 2015 14:41:32 -0400 Date: Wed, 29 Jul 2015 19:40:43 +0100 From: Mark Brown To: Michal Suchanek Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , David Woodhouse , Brian Norris , Kukjin Kim , Krzysztof Kozlowski , Padmavathi Venna , Boris BREZILLON , devicetree , Linux Kernel Mailing List , MTD Maling List , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , linux-spi Message-ID: <20150729184043.GL11162@sirena.org.uk> References: <557c1962448393b2a8736f26bfa2a3a5ba4aeb7a.1438170519.git.hramrach@gmail.com> <20150729140046.GB11082@sirena.org.uk> <20150729171613.GI11162@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="akWijmsqBEgP5JG6" Content-Disposition: inline In-Reply-To: X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1723 Lines: 47 --akWijmsqBEgP5JG6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 29, 2015 at 08:21:34PM +0200, Michal Suchanek wrote: > On 29 July 2015 at 19:16, Mark Brown wrote: > >> It will not break anything. It will just spam dmesg. > > I'm confused - if all this change does is to spam dmesg then what's the > > point? > Presumably when your SPI NOR flash fails to probe this message will be > just above and you will look into the binding doc and add the > compatible. If you're looking to add a warning message when the flash device fails to probe then add that in the flash driver when it detects an error, this will cause needless noise for everyone else using this controller purely to work around the broken binding. And like I say compatible really seems like it isn't an appropriate property here. --akWijmsqBEgP5JG6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVuR4qAAoJECTWi3JdVIfQw84H+gIG06W1d5C+xW+3hdwVcySH U+hKQACjqxbhWce28likOpb+KV3qC8Vqp4vRNYrfTgQbpJfnI4Sz/0q6UW28FL2y ybxkDt3/XMC9D4fWRodIDZYUxEm/76Z0/y1h0VAwXSHMS8bziwltgiTVMfpxRhPv yXOFjuhdMDHQcoTzj34vBpep1c6RT6ymMw0C0szqmElwDUvcMvh1GTidkDTTk/nQ o/IrC2dXrjQF12YpuwRPpth98ZR2b38WkVa/Fd/nyCTbvRWiwdAY7Yn3tBTD/Hns w1GsUiOys9kPykg/qeBOI5sLr/Y2GmYeYzz4hUdfENXDo3CCm2T62riqAjUfNng= =+uJe -----END PGP SIGNATURE----- --akWijmsqBEgP5JG6-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/