Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753484AbbG2T6L (ORCPT ); Wed, 29 Jul 2015 15:58:11 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56440 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbbG2T6J (ORCPT ); Wed, 29 Jul 2015 15:58:09 -0400 Message-ID: <55B9304E.6020408@roeck-us.net> Date: Wed, 29 Jul 2015 12:58:06 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Moore, Robert" , "rjw@rjwysocki.net" CC: "lenb@kernel.org" , "Zheng, Lv" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@acpica.org" Subject: Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul() References: <1438043542-2960-1-git-send-email-linux@roeck-us.net> <94F2FBAB4432B54E8AACC7DFDE6C92E37D329493@ORSMSX112.amr.corp.intel.com> <55B91DAF.3060605@roeck-us.net> <94F2FBAB4432B54E8AACC7DFDE6C92E37D3294E8@ORSMSX112.amr.corp.intel.com> In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D3294E8@ORSMSX112.amr.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2139 Lines: 55 On 07/29/2015 12:33 PM, Moore, Robert wrote: >> -----Original Message----- >> From: Guenter Roeck [mailto:linux@roeck-us.net] >> Sent: Wednesday, July 29, 2015 11:39 AM >> To: Moore, Robert; rjw@rjwysocki.net >> Cc: lenb@kernel.org; Zheng, Lv; linux-acpi@vger.kernel.org; linux- >> kernel@vger.kernel.org; devel@acpica.org >> Subject: Re: [PATCH v2] acpi: Use kstrtoul() instead of >> strtoul()/simple_strtoul() >> >> On 07/29/2015 10:51 AM, Moore, Robert wrote: >>> >>> >>>> -----Original Message----- >>>> From: Guenter Roeck [mailto:linux@roeck-us.net] >>>> Sent: Monday, July 27, 2015 5:32 PM >>>> To: rjw@rjwysocki.net >>>> Cc: lenb@kernel.org; Moore, Robert; Zheng, Lv; >>>> linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; >>>> devel@acpica.org; Guenter Roeck >>>> Subject: [PATCH v2] acpi: Use kstrtoul() instead of >>>> strtoul()/simple_strtoul() >>>> >>>> simple_strtoul() is deprecated; replace with kstrtoul() and >> kstrtouint(). >>> >>> The ACPICA code is os-independent and cannot use these functions (at >> least not directly). >>> >>> >> Odd argument, given that kstrtoul() is used already in the acpi code. > > They are not in the os-independent ACPICA code. The ACPI-related drivers are another story, since they are OS-dendent. > That this OS independent code mandates functions such as strtoul(), which may not exist in a target OS, and that it maps strtoul() to simple_strtoul() in a global include file, doesn't seem to be correct either and is asking for repeated trouble. I would have hoped that at the very least such mappings would be implemented in local include files. On the other side, my patch to remove the second global definition of strtoul has been accepted, so the problem I was trying to solve has been addressed elsewhere. With that, my patch is no longer needed at this time, at least until someone else redefines strtoul(). Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/