Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754603AbbG2W2g (ORCPT ); Wed, 29 Jul 2015 18:28:36 -0400 Received: from neil.brown.name ([103.29.64.221]:36672 "EHLO vanity" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754579AbbG2W2d (ORCPT ); Wed, 29 Jul 2015 18:28:33 -0400 X-Greylist: delayed 1032 seconds by postgrey-1.27 at vger.kernel.org; Wed, 29 Jul 2015 18:28:32 EDT Date: Thu, 30 Jul 2015 08:10:46 +1000 From: NeilBrown To: jake42 Cc: Sebastian Reichel , , , , Pavel Machek , , Lee Jones , List for communicating with real GTA04 owners Subject: Re: [Gta04-owner] [PATCH 08/14] twl4030_charger: allow max_current to be managed via sysfs. Message-ID: <20150730081046.027ba82e@home.neil.brown.name> In-Reply-To: References: <20150322231635.23789.70149.stgit@notabene.brown> <20150322232029.23789.13768.stgit@notabene.brown> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1484 Lines: 48 On Mon, 23 Mar 2015 13:14:50 +0100 jake42 wrote: > Hello Neil, > > some suggestions: > > On 23.03.2015 00:20, NeilBrown wrote: > > From: NeilBrown > > diff --git a/Documentation/ABI/testing/sysfs-class-power-twl4030 > > b/Documentation/ABI/testing/sysfs-class-power-twl4030 > > new file mode 100644 > > index 000000000000..06092209d851 > > --- /dev/null > > +++ b/Documentation/ABI/testing/sysfs-class-power-twl4030 > > @@ -0,0 +1,15 @@ > > +What: /sys/class/power_supply/twl4030_ac/max_current > > + /sys/class/power_supply/twl4030_usb/max_current > > +Description: > > + Read/Write limit on current which which may > one less which ^^ > > + be drawn from the ac (Accessory Charger) or > > + USB port. > > + > > + Value is in micro-Amps. > > + > > + Value is set automatically to an appropriate > > + value when a cable is plugged on unplugged. > s/on/or ^^ > > + > > + Value can the set by writing to the attribute. > ^^ be set? > > + The change will only persist until the next > > + plug event. These event are reported via udev. > > Regards > Jake > Thanks. I've made those two changes. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/