Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754153AbbG2WTh (ORCPT ); Wed, 29 Jul 2015 18:19:37 -0400 Received: from mga14.intel.com ([192.55.52.115]:8578 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371AbbG2WTd (ORCPT ); Wed, 29 Jul 2015 18:19:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,572,1432623600"; d="scan'208";a="532575584" From: Keith Busch To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bjorn Helgass , Dave Jiang Subject: [PATCH 3/3] PCIE: Remove symbol export for pcie_set_mps() Date: Wed, 29 Jul 2015 16:18:55 -0600 Message-Id: <1438208335-19457-4-git-send-email-keith.busch@intel.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1438208335-19457-1-git-send-email-keith.busch@intel.com> References: <1438208335-19457-1-git-send-email-keith.busch@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 32 From: Dave Jiang The setting of PCIe MPS should be left to the PCI subsystem and not the driver. An ill configured MPS by the driver could cause the device to not function or unstablize the entire system. Removing the exported symbol. Signed-off-by: Dave Jiang --- drivers/pci/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 0008c95..92349ee 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4121,7 +4121,6 @@ int pcie_set_mps(struct pci_dev *dev, int mps) return pcie_capability_clear_and_set_word(dev, PCI_EXP_DEVCTL, PCI_EXP_DEVCTL_PAYLOAD, v); } -EXPORT_SYMBOL(pcie_set_mps); /** * pcie_get_minimum_link - determine minimum link settings of a PCI device -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/