Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754293AbbG2WWA (ORCPT ); Wed, 29 Jul 2015 18:22:00 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:32813 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753832AbbG2WV6 (ORCPT ); Wed, 29 Jul 2015 18:21:58 -0400 MIME-Version: 1.0 In-Reply-To: <20150727080347.GA18599@lst.de> References: <20150725023649.8664.59145.stgit@dwillia2-desk3.amr.corp.intel.com> <20150725024015.8664.42950.stgit@dwillia2-desk3.amr.corp.intel.com> <20150727080347.GA18599@lst.de> Date: Wed, 29 Jul 2015 15:21:56 -0700 Message-ID: Subject: Re: [PATCH v2 24/25] arch: remove ioremap_wt, replace with arch_memremap From: Dan Williams To: Christoph Hellwig Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-arch@vger.kernel.org, Tony Luck , "Kani, Toshimitsu" , Arnd Bergmann , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , Borislav Petkov , Russell King , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 51 On Mon, Jul 27, 2015 at 1:03 AM, Christoph Hellwig wrote: >> +++ b/arch/frv/include/asm/io.h >> @@ -17,8 +17,6 @@ >> >> #ifdef __KERNEL__ >> >> -#define ARCH_HAS_IOREMAP_WT >> - >> #include >> #include >> #include >> @@ -267,20 +265,17 @@ static inline void __iomem *ioremap_nocache(unsigned long physaddr, unsigned lon >> return __ioremap(physaddr, size, IOMAP_NOCACHE_SER); >> } >> >> -static inline void __iomem *ioremap_wt(unsigned long physaddr, unsigned long size) >> -{ >> - return __ioremap(physaddr, size, IOMAP_WRITETHROUGH); >> -} >> - >> -static inline void __iomem *ioremap_fullcache(unsigned long physaddr, unsigned long size) >> -{ >> - return __ioremap(physaddr, size, IOMAP_FULL_CACHING); >> -} > > >> +void *arch_memremap(resource_size_t offset, size_t size, unsigned long flags) >> +{ >> + return (void *) offset; >> +} >> +EXPORT_SYMBOL(arch_memremap); > > This doesn't look like a correct replacement. It doesn't, but frv jumps through a lot of hoops to give the illusion it actually supports different mapping types only to do this simple case in the end. Given we don't want fallback semantics I will simply remove these false wrappers in the next revision of the patches. > Also shouldn't the replacements of ioremap_fullcache or ioremap_wc be > in the previous patch? > > A few more similar issues pop up for other architectures as well. I went ahead and moved the deletion of ioremap_cached() and ioremap_fullcache() to their own patches. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/