Message-ID: <1438219687.2374.1.camel@ellerman.id.au>
Subject: Re: samples/kdbus/kdbus-workers.c and cross compiling MIPS
From: Michael Ellerman <mpe@ellerman.id.au>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: dh.herrmann@googlemail.com, gregkh@linuxfoundation.org, daniel@zonque.org,
        tixxdz@opendz.org, linux-mips@linux-mips.org,
        linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Date: Thu, 30 Jul 2015 11:28:07 +1000
In-Reply-To: <20150729161912.GF18685@windriver.com>
References: <20150729161912.GF18685@windriver.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1563
Lines: 38

On Wed, 2015-07-29 at 12:19 -0400, Paul Gortmaker wrote:
> Hi David,
> 
> Does it make sense to build this sample when cross compiling?
> 
> The reason I ask is that it has been breaking the linux-next build of
> allmodconfig for a while now, with:
> 
>   HOSTCC  samples/kdbus/kdbus-workers
> samples/kdbus/kdbus-workers.c: In function ‘prime_new’:
> samples/kdbus/kdbus-workers.c:934:18: error: ‘__NR_memfd_create’ undeclared (first use in this function)
>   p->fd = syscall(__NR_memfd_create, "prime-area", MFD_CLOEXEC);
>                   ^
> samples/kdbus/kdbus-workers.c:934:18: note: each undeclared identifier is reported only once for each function it appears in
> scripts/Makefile.host:91: recipe for target 'samples/kdbus/kdbus-workers' failed
> make[2]: *** [samples/kdbus/kdbus-workers] Error 1
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12473453/
> 
> We recently made some changes to skip other sample/test programs when
> cross compiling in mainline 65f6f092a6987 and f59514b6a8c5ca6dd and
> 6a407a81a9abcf.  Maybe it makes sense to do the same here?

Hi Paul,

We also can configure kisskb to not build samples for all_modconfig, which
avoids these sort of issues with a slight decrease in code coverage. We already
disable samples for several other arch all_modconfigs.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/