Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbbG3Dir (ORCPT ); Wed, 29 Jul 2015 23:38:47 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:33261 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbbG3Diq (ORCPT ); Wed, 29 Jul 2015 23:38:46 -0400 MIME-Version: 1.0 In-Reply-To: <871tfrkree.fsf@ashishki-desk.ger.corp.intel.com> References: <1436177344-16751-1-git-send-email-alexander.shishkin@linux.intel.com> <1436177344-16751-2-git-send-email-alexander.shishkin@linux.intel.com> <877fpjkseh.fsf@ashishki-desk.ger.corp.intel.com> <20150729133529.GI20130@sirena.org.uk> <871tfrkree.fsf@ashishki-desk.ger.corp.intel.com> Date: Thu, 30 Jul 2015 11:38:45 +0800 Message-ID: Subject: Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices From: Chunyan Zhang To: Alexander Shishkin Cc: Mark Brown , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Mathieu Poirier , peter.lachner@intel.com, norbert.schulz@intel.com, keven.boell@intel.com, yann.fouassier@intel.com, laurent.fert@intel.com, "linux-api@vger.kernel.org" , Chunyan Zhang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1302 Lines: 35 On Wed, Jul 29, 2015 at 9:46 PM, Alexander Shishkin wrote: > Mark Brown writes: > >> On Wed, Jul 29, 2015 at 04:25:10PM +0300, Alexander Shishkin wrote: >> >>> There has to be a way to defer stm_probe(), although a quick look at >>> amba code suggests it's not implemented. >> >> What makes you say this? Probe deferral is implemented in the driver >> core rather than individual buses, the buses don't need to know anything >> about it. > > I stand corrected, it indeed is. > > So returning EPROBE_DEFER from stm_probe() should Just Work (provided > stm_probe() handles its error paths correctly). If let stm_probe() implement probe deferral, it has to have a global variable for the later calling of "stm_register_device", because the first parameter of "stm_register_device" is " struct device * " which comes from amba_probe(), after finished amba_probe(), we may not get this structure by other means. This was a similar policy that we both thought was not good :) > > Regards, > -- > Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/