Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754689AbbG3Gzi (ORCPT ); Thu, 30 Jul 2015 02:55:38 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38742 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754644AbbG3Gzf (ORCPT ); Thu, 30 Jul 2015 02:55:35 -0400 Message-ID: <1438239331.2144.18.camel@linaro.org> Subject: Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect From: "Ivan T. Ivanov" To: Tim Bird Cc: Peter Chen , Linux Kernel Mailing List , "linux-usb@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Date: Thu, 30 Jul 2015 09:55:31 +0300 In-Reply-To: References: <1433250873-20780-1-git-send-email-ivan.ivanov@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2209 Lines: 57 On Wed, 2015-07-29 at 12:10 -0700, Tim Bird wrote: > On Tue, Jun 2, 2015 at 6:14 AM, Ivan T. Ivanov ivanov@linaro.org> wrote: > > On recent Qualcomm platforms VBUS and ID lines are not routed to > > USB PHY LINK controller. Use extcon framework to receive connect > > and disconnect ID and VBUS notification. > > > > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org> > > --- > > Changes sice v2 [1]. > > > > * Simulate IRQ on extcon event - used to trigger OTG state machine. > > > > I have to admit that I couldn't test complete Chipidea OTG state machine, > > because my setup is little weird. I am using "qcom,usb-otg-ci" as PHY/OTG > > provider, "qcom,ehci-host" as host controller driver and "qcom,ci-hdrc" for > > device role. > > Ivan, > > Do you have patches for the code (presumably pmic code) where the vbus and id > lines are signaled? Presumably you've added some extcon_set_cable_state() calls > somewhere in your source tree, for this to work. I'm wondering if you > can share your > work in progress, or let me know when you plan to push that upstream? > Well, not exactly. Maybe change description is badly worded. I have DB410c where VBUS and ID lines are not routed to USB controller, but to GPIO. So from the chipidea core driver point of view ID and VBUS changes/IRQs are triggered from extcon driver "linux,extcon-usb-gpio" > I'm interested in testing the msm usb code (specifically host mode support) > on my dragonboard here. > Since yesterday, Felipe kindly merged simple usb-phy driver for 8x16[1]. Which allow just using "qcom,ci-hdrc" and "qcom,usb-8x16-phy" to have DRD support on 8x16 chipsets. I have tried to use "chipidea,usb2", but unfortunately quirks in "qcom,ci-hdrc" are required. Once we have similar usb-phy drivers for 8x60, 8064, 8074 and 8084, I believe the we can remove "qcom,usb-otg-xxx" monster. usb-phy driver for 8074 should be very similar to 8x16 one. Regards, Ivan [1] http://bit.ly/1U6IjK4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/