Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754625AbbG3HQj (ORCPT ); Thu, 30 Jul 2015 03:16:39 -0400 Received: from mga14.intel.com ([192.55.52.115]:20635 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109AbbG3HQg (ORCPT ); Thu, 30 Jul 2015 03:16:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,575,1432623600"; d="scan'208";a="738608510" From: Alexander Shishkin To: Chunyan Zhang Cc: Greg Kroah-Hartman , "linux-kernel\@vger.kernel.org" , Mathieu Poirier , peter.lachner@intel.com, norbert.schulz@intel.com, keven.boell@intel.com, yann.fouassier@intel.com, laurent.fert@intel.com, "linux-api\@vger.kernel.org" , Chunyan Zhang , Mark Brown Subject: Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices In-Reply-To: References: <1436177344-16751-1-git-send-email-alexander.shishkin@linux.intel.com> <1436177344-16751-2-git-send-email-alexander.shishkin@linux.intel.com> <877fpjkseh.fsf@ashishki-desk.ger.corp.intel.com> <87vbd29mm6.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 30 Jul 2015 10:16:19 +0300 Message-ID: <87si869ku4.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 38 Chunyan Zhang writes: > The code has already been submitted like I said in the earlier emails, > you may refer [1]. > > Thanks, > Chunyan > > [1] https://lkml.org/lkml/2015/2/4/729 This code does the following (pasting from that patch): in stm_probe(): drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); ... something irrelevant ... ret = clk_prepare_enable(drvdata->clk); ... something irrelevant ... clk_disable_unprepare(drvdata->clk); ... something irrelevant ... drvdata->clk = adev->pclk; How is this supposed to even work? Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/