Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755251AbbG3JMq (ORCPT ); Thu, 30 Jul 2015 05:12:46 -0400 Received: from mga03.intel.com ([134.134.136.65]:16614 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754817AbbG3JMn (ORCPT ); Thu, 30 Jul 2015 05:12:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,576,1432623600"; d="scan'208";a="774360250" Subject: Re: [Bugfix] x86, irq: Fix regression caused by commit d32932d02e18 To: Matt Fleming References: <1438242695-23531-1-git-send-email-jiang.liu@linux.intel.com> <20150730090747.GA2704@codeblueprint.co.uk> Cc: Thomas Gleixner , Ingo Molnar , Chen Yu , "H. Peter Anvin" , x86@kernel.org, Yinghai Lu , Tony Luck , linux-kernel@vger.kernel.org From: Jiang Liu Organization: Intel Message-ID: <55B9EA87.80006@linux.intel.com> Date: Thu, 30 Jul 2015 17:12:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150730090747.GA2704@codeblueprint.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1668 Lines: 38 On 2015/7/30 17:07, Matt Fleming wrote: > On Thu, 30 Jul, at 03:51:32PM, Jiang Liu wrote: >> Commit d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical >> irqdomain interfaces") introduced a regression when converting IOAPIC >> to hierarchy irqdomain, which sets wrong irq flow handler for IOAPIC >> pins on Surface Pro 3 and causes failure when detecting I2C controllers. >> It's caused by using stale attribute value when setting up IOAPIC pins. >> With this patch applied, all IOAPIC IRQ configuration are identical >> to v4.1 on Surface Pro 3. >> >> Fixes: d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical irqdomain interfaces") >> Reported-by: Matt Fleming >> Tested-and-reported-by: Chen Yu >> Signed-off-by: Jiang Liu >> --- >> Hi Matt, >> Could you please help to test this patch? >> Thanks! >> Gerry >> --- >> arch/x86/kernel/apic/io_apic.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Works for me! What I actually did was apply this fixup commit ontop of > commit d32932d02e18, just to be sure that it fixes the issue. I'm about > to apply it on top of -rc4 just to be sure. Hi Matt, Chen found there are other issues with 4.2-rc4 which breaks Surface Pro 3's I2C and multitouch drivers. If you run into the same trouble, please contact Chen Yu for details:) Thanks! Gerry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/