Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755419AbbG3JYe (ORCPT ); Thu, 30 Jul 2015 05:24:34 -0400 Received: from mail-vk0-f46.google.com ([209.85.213.46]:35367 "EHLO mail-vk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755098AbbG3JYb (ORCPT ); Thu, 30 Jul 2015 05:24:31 -0400 MIME-Version: 1.0 In-Reply-To: <20150730105923-mutt-send-email-mst@redhat.com> References: <1438196676-30255-1-git-send-email-mst@redhat.com> <55B97C88.6010004@linaro.org> <20150730105923-mutt-send-email-mst@redhat.com> From: Peter Maydell Date: Thu, 30 Jul 2015 10:24:11 +0100 Message-ID: Subject: Re: [Qemu-devel] [PATCH v2] arm: change vendor ID for virtio-mmio To: "Michael S. Tsirkin" Cc: Shannon Zhao , QEMU Developers , Graeme Gregory , lkml - Kernel Mailing List , "virtualization@lists.linux-foundation.org" , Shannon Zhao , Igor Mammedov , =?UTF-8?B?QWxleCBCZW5uw6ll?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 35 On 30 July 2015 at 09:04, Michael S. Tsirkin wrote: > On Thu, Jul 30, 2015 at 09:23:20AM +0800, Shannon Zhao wrote: >> >> Why do we drop the previous way using "QEMUXXXX"? Something I missed? > > So that guests that bind to this interface will work fine with non QEMU > implementations of virtio-mmio. I don't understand this sentence. If there are pre-existing non-QEMU virtio-mmio implementations, then they're using LNRO0005, and we should use it too. If there are going to be implementations of virtio-mmio in future, then they will use whatever identifier we pick here. Either way, we get interoperability. I don't see any difference between our saying "the ID for virtio-mmio is QEMU0005" and saying "the ID for virtio-mmio is 1AF4103F". (The latter seems unnecessarily opaque to me, to be honest. At least an ID string QEMUxxxx gives you a clue where to look for who owns the thing.) Note also that strictly you don't mean "non-QEMU implementations of virtio-mmio", you mean "non-QEMU implementations of the ACPI tables". The hardware implementation of virtio-mmio doesn't care at all about the ACPI ID. (In fact the most plausible other-implementation would be UEFI using its own (hard-coded) ACPI tables on top of a QEMU vexpress-a15 model or something similar.) -- PMM -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/