Date: Thu, 30 Jul 2015 11:11:31 +0100
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>, "Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        x86@kernel.org, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org, "Lee, Chun-Yi" <jlee@suse.com>
Subject: Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions
 to different starting virtual address
Message-ID: <20150730101131.GB2725@codeblueprint.co.uk>
References: <1438230757-30840-1-git-send-email-jlee@suse.com>
 <55B9D806.7030705@zytor.com>
 <20150730080323.GD8984@nazgul.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150730080323.GD8984@nazgul.tnic>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1454
Lines: 34

On Thu, 30 Jul, at 10:03:23AM, Borislav Petkov wrote:
> On Thu, Jul 30, 2015 at 12:53:42AM -0700, H. Peter Anvin wrote:
> > This changelog is at least partially incomprehensive. It also seems
> > more than a bit aggressive to expect that 1 GB will be sufficient
> > forever.
> 
> Right, before we do anything, I'd like for us to figure out first why
> this is a problem all of a sudden. And why should we even keep boot
> code/data, if it is fair game, once runtime services get enabled.
> 
> Matt, can you please chime in first before we even talk about a
> solution...

Yeah, I do not understand the issue properly.

Why do we care about EfiBoot* regions after hibernate? Surely we've
already freed those regions in efi_free_boot_services() during boot and
nobody should be touching them again? If the firmware does, that's a
whole new bug we've never encountered before.

And we obviously can't allow the runtime regions to move around during
hibernate/resume because we've already informed the firmware where those
regions live during SetVirtualAddressMap() at boot.

I admit that I haven't looked at the hibernate code paths. Let me go do
that now.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/