Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754901AbbG3KMx (ORCPT ); Thu, 30 Jul 2015 06:12:53 -0400 Received: from www.linutronix.de ([62.245.132.108]:45537 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638AbbG3KMv (ORCPT ); Thu, 30 Jul 2015 06:12:51 -0400 Date: Thu, 30 Jul 2015 12:12:29 +0200 (CEST) From: Thomas Gleixner To: Taichi Kageyama cc: Peter Hurley , "gregkh@linuxfoundation.org" , "jiang.liu@linux.intel.com" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jslaby@suse.cz" , "prarit@redhat.com" , Naoya Horiguchi , Peter Zijlstra Subject: Re: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console In-Reply-To: <55B980E6.70800@cp.jp.nec.com> Message-ID: References: <1438157443-19447-1-git-send-email-t-kageyama@cp.jp.nec.com> <55B8BE39.6080500@hurleysoftware.com> <55B8D26A.7000402@hurleysoftware.com> <55B980E6.70800@cp.jp.nec.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 25 On Thu, 30 Jul 2015, Taichi Kageyama wrote: > On 2015/07/29 22:35, Thomas Gleixner wrote: > I know your code is sample (console.h is required), > but it is conflict with [patch v2 1/3]. > I think serial8250_console_write should not touch ctrl reg during autoconfig_irq. > To resolve the real problem, I think keeping only [patch v2 1/3] is best(opt1). > What do you think? > > opt1. keep [patch v2 1/3] > + Don't touch other legacy drivers using autoprobe. > Each driver can use console_lock to fix this problem if it happens. No, we already know that autoprobing and console access can cause this, so we fix it at the core code and be done with it. Can you please test Peters patch and confirm that is solves it. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/