From: Dexuan Cui <decui@microsoft.com>
To: David Miller <davem@davemloft.net>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "stephen@networkplumber.org" <stephen@networkplumber.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "driverdev-devel@linuxdriverproject.org" 
	<driverdev-devel@linuxdriverproject.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "apw@canonical.com" <apw@canonical.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        KY Srinivasan <kys@microsoft.com>,
        "pebolle@tiscali.nl" <pebolle@tiscali.nl>,
        "stefanha@redhat.com" <stefanha@redhat.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>
Subject: RE: [PATCH V4 6/7] hvsock: introduce Hyper-V VM Sockets feature
Thread-Topic: [PATCH V4 6/7] hvsock: introduce Hyper-V VM Sockets feature
Thread-Index: AQHQyk3L4K6K+84GbkijOqwy4UXhV53zdtdQ
Date: Thu, 30 Jul 2015 10:17:44 +0000
Message-ID: <4cd0704b1a324edc9330b11b006d8574@SIXPR30MB031.064d.mgd.msft.net>
References: <1438086923-19450-1-git-send-email-decui@microsoft.com>
 <20150729.152737.853332463848886188.davem@davemloft.net>
In-Reply-To: <20150729.152737.853332463848886188.davem@davemloft.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
CY1PR0301MB1579: X-MS-Exchange-Organization-RulesExecuted
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2015 10:17:50.2601
 (UTC)
X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;Ip=[206.191.229.116];Helo=[064-smtp-out.microsoft.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1579
X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1548;2:TyKZmPcQsqt49LXoQlMLv4AXgsO8JAXgPTgC4F7EfBY0crzQCxvEi6OU+qgRefgQmB8zgxhlCNzYoBS7SmisEnP7SyxYFgGl0tydmINqBt3nbN32wI1rMKjb/0BU2fiYn0NSZFMQ0N7RJTE7EFcM/EwFYpqKyEhacyWCnbW94wc=;3:kesCRMvBXhZFcRtZNUx2pv3cCGaFF3cc23vTs+VumqE2MGOfhwaN+XT/csvp8YzPWGFXXn8OEtkkHXZRk+rqK/yCCO+0Q27kmgSC/5IJtoRb3JJ//v5CgYWNo5FlW7AYrVu2VINkPXCIirWpHz6cWkc0XsbO/V75mDtHU32743/S7zlH7a4y/m/ulkLZ2LHc3en7v/6jrcp7//B3USAZ9oz2C7PeiaXjOtbQr1FRxMwe9NF1RXLyo+R2CqN3hCsW;25:KPY+/0DTu/3edyKSgTQ1I0hKR8Api175VrCdOxN68m5NbBfG1DZRNXo+j/tkiYOeJHPywrMSFMp/i78EObfGPHOThzI/CsQmZ6XQVag0clGTtm/OD9HuhP/s+VukPjfKSsQfS376YjkwrN2epfONWv+TJk2aSWamR5SDhvflJ80WyD/jdH8t12zStUXBrxwfEkB2TU5fIQCSPiAT3Ocdz5/awITTA2Gmhhg2Cl0Gi7UAnhf64bPL5ZIuPZhXQZOHTIDAooQYTaunXyRo4Nb4Fw==;20:nT0G+AkkqbNxMvPeQsm5DcDKanPbeLnKU9mH6OiB71boeNjm25GJ+N6X+1qNC+rCU3EAfUAQ3hjYOznwnqAtvQ==
CY1PR0301MB1548: X-MS-Exchange-Organization-RulesExecuted
X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1548;23:2gGnb/uixHS2l61hCggIjrOG7o8iZQ8pm8Hk/FnJn697qJ9g6rahpFrrwMD/m06f6QDxAA9an5U+Wys3/vE0enj/ziueo08SjhTB/5+5K3rIE784csM88w38N3zAkAessOX8yInZAJaNpQ4DBgVIOoDQd4z4L6vkRh6Z6QAILtNy3qvxGzCf8Ktxz1giULeSloTGBF4wE7KSgK8sSnVlmktvSBUvUTwdiYRkw9b2BbqeIB8WPgnpy6Ds8d+gWyZt
X-OriginatorOrg: microsoft.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1561
Lines: 50

> From: David Miller
> Sent: Thursday, July 30, 2015 6:28
> >From: Dexuan Cui
> >Date: Tue, 28 Jul 2015 05:35:23 -0700
> >
> > +/* hvsock_release() can be invoked in 2 paths:
> > + * 1. on process termination:
> > + *	hvsock_sk_destruct+0x1a/0x20
> > + *	__sk_free+0x1d/0x130
> > + *	sk_free+0x19/0x20
> > + *	hvsock_release+0x138/0x160
> > + *	sock_release+0x1f/0x90
> > + *	sock_close+0x12/0x20
> > + *	__fput+0xdf/0x1f0
> > + *	____fput+0xe/0x10
> > + *	task_work_run+0xd4/0xf0
> > + *	do_exit+0x334/0xb90
> > + *	? __do_page_fault+0x1e1/0x490
> > + *	? lockdep_sys_exit_thunk+0x35/0x67
> > + *	do_group_exit+0x54/0xe0
> > + *	SyS_exit_group+0x14/0x20
> > + *	system_call_fastpath+0x16/0x1b
> > + *
> > + *  2. when accept() returns -ENITR:
> > + *	hvsock_release+0x151/0x160
> > + *	sock_release+0x1f/0x90
> > + *	sock_close+0x12/0x20
> > + *	__fput+0xdf/0x1f0
> > + *	____fput+0xe/0x10
> > + *	task_work_run+0xb7/0xf0
> > + *	get_signal+0x750/0x770
> > + *	do_signal+0x28/0xbb0
> > + *	? put_unused_fd+0x52/0x60
> > + *	? SYSC_accept4+0x1ca/0x220
> > + *	do_notify_resume+0x4f/0x90
> > + *	int_signal+0x12/0x17
> > + */
> 
> It is a bit much to put full stack backtraces into a comment like this.

Thanks for reviewing the patch, David!
I'll remove these lines and add a proper comment here.

Thanks,
-- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/