Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753898AbbG3Kaq (ORCPT ); Thu, 30 Jul 2015 06:30:46 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:45523 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbbG3Kap (ORCPT ); Thu, 30 Jul 2015 06:30:45 -0400 Date: Thu, 30 Jul 2015 12:30:37 +0200 From: Peter Zijlstra To: Xunlei Pang Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Xunlei Pang Subject: Re: [PATCH] sched: Avoid sched domain rebuilding when hotplugging an isolate cpu Message-ID: <20150730103037.GU19282@twins.programming.kicks-ass.net> References: <1437120225-16466-1-git-send-email-xlpang@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437120225-16466-1-git-send-email-xlpang@126.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 16 On Fri, Jul 17, 2015 at 04:03:45PM +0800, Xunlei Pang wrote: > From: Xunlei Pang > > The sched domain is always rebuilt when hotplugging an isolate cpu, > as we can see in partition_sched_domains() with the NULL doms_new, > current sched domain is destroyed, then rebuilt. Worse still, the > rebuilding will reset all the parameters of the sched_domain. This > makes no sense and contradicts the isloate concept. What parameters? isolcpus should have fairly trivial domains to begin with. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/