Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755493AbbG3KxG (ORCPT ); Thu, 30 Jul 2015 06:53:06 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46427 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410AbbG3KxB (ORCPT ); Thu, 30 Jul 2015 06:53:01 -0400 Date: Thu, 30 Jul 2015 11:52:33 +0100 From: Mark Brown To: Michal Suchanek Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , David Woodhouse , Brian Norris , Kukjin Kim , Krzysztof Kozlowski , Padmavathi Venna , Boris BREZILLON , devicetree , Linux Kernel Mailing List , MTD Maling List , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , linux-spi Message-ID: <20150730105233.GO11162@sirena.org.uk> References: <557c1962448393b2a8736f26bfa2a3a5ba4aeb7a.1438170519.git.hramrach@gmail.com> <20150729140046.GB11082@sirena.org.uk> <20150729171613.GI11162@sirena.org.uk> <20150729184043.GL11162@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9VrpJA1Ggqg13J4y" Content-Disposition: inline In-Reply-To: X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1640 Lines: 45 --9VrpJA1Ggqg13J4y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 30, 2015 at 10:24:37AM +0200, Michal Suchanek wrote: > So my suggestion is to > 1) search of ofpart subnode in mtd node. If present read address and > reg from it and search partitions as subnodes of the ofpart node. In > this case unknown nodes can cause error. > 2) failing that issue a warning and try to parse ofpart partitions > from the mtd node itself. In this case unknown nodes cannot cause > error for compatibility with other drivers including the already > exisitn s3c64xx controller-data node. > The parser code can be the same for both cases and only operate on > different node with a flag to reject unknown subnodes or not. That seems reasonable to me. --9VrpJA1Ggqg13J4y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVugHxAAoJECTWi3JdVIfQdZwIAIVmxlDqQRuMpGGZjMcMZoD6 2BQ+6Sj04M6QWBFYkqvm3Dp6xMHJ9r0nre0HSmUcztLmYPtsnv+scgPOiO523am8 mv5BJcmVGejsSbwYEf1rxHM2bGeD9MUmmfr9BrQsr19RmaO6K3G9lSKa8znCfRsx FiKKMWdpl97JVdAvES0KC4rbpnGUpUtNNLeuzI1+17l8bzcv0NmwuG/wf2zfLjku q9FF2UNSExyz/7uQezKiwG9HlmPQkE7wxVUNleYQM1VWwsBgtjgTU5ncj5lZ6RY0 zML7Y/sWu93tWX5cBAV5cB49sxzE7erz0e2pV330cHSnPIda/eHyoZ8b7c9iQFw= =/zjp -----END PGP SIGNATURE----- --9VrpJA1Ggqg13J4y-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/