Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbbG3MC3 (ORCPT ); Thu, 30 Jul 2015 08:02:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43274 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbbG3MC2 (ORCPT ); Thu, 30 Jul 2015 08:02:28 -0400 Date: Thu, 30 Jul 2015 08:02:24 -0400 From: Neil Horman To: yalin wang Cc: Thomas Gleixner , Andrew Morton , David Kershner , tj@kernel.org, laijs@cn.fujitsu.com, nacc@linux.vnet.ibm.com, mingo@redhat.com, linux-kernel@vger.kernel.org, jes.sorensen@redhat.com, sparmaintainer@unisys.com Subject: Re: [PATCH v2] kthread: Export kthread functions Message-ID: <20150730120223.GA27430@hmsreliant.think-freely.org> References: <1437777920-31156-1-git-send-email-david.kershner@unisys.com> <1438099141-8614-1-git-send-email-david.kershner@unisys.com> <20150728142748.a756d7540ad5cdaf4c9efc9e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2099 Lines: 51 On Thu, Jul 30, 2015 at 11:48:17AM +0800, yalin wang wrote: > > > On Jul 29, 2015, at 18:34, Thomas Gleixner wrote: > > > > On Tue, 28 Jul 2015, Andrew Morton wrote: > > > >> On Tue, 28 Jul 2015 11:59:01 -0400 David Kershner wrote: > >> > >>> The s-Par visornic driver, currently in staging, processes a queue > >>> being serviced by the an s-Par service partition. We can get a message > >>> that something has happened with the Service Partition, when that > >>> happens, we must not access the channel until we get a message that the > >>> service partition is back again. > >>> > >>> The visornic driver has a thread for processing the channel, when we > >>> get the message, we need to be able to park the thread and then resume > >>> it when the problem clears. > >>> > >>> We can do this with kthread_park and unpark but they are not exported > >>> from the kernel, this patch exports the needed functions. > >>> > >>> Signed-off-by: David Kershner > >> > >> Please accumulate the acked-by's and reviewed-by's in the changelog as > >> they are received. I presently have > >> > >> Acked-by: Ingo Molnar > >> Acked-by: Neil Horman > >> Cc: Thomas Gleixner > >> Cc: Richard Weinberger > >> Cc: Tejun Heo > >> > >> > >> I'll scoot this into mainline probably this week to make life simpler > >> for the various trees. > > > i am curious why not make some tiny functions to be inline ? > so that don’t need EXPORT_SYMOBLS , shrink the kernel size. > Thanks Because exporting symbols isn't a big deal, and the compiler can decide when its best to inline these functions. As it is, they aren't that small, if you expand all their internals Neil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/