Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752655AbbG3MMt (ORCPT ); Thu, 30 Jul 2015 08:12:49 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:33946 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752544AbbG3MMr convert rfc822-to-8bit (ORCPT ); Thu, 30 Jul 2015 08:12:47 -0400 Message-ID: <1438258362.3969.194.camel@collabora.co.uk> Subject: Re: [PATCH] Bluetooth: btusb: Recognize Realtek shared wifi/bluetooth devices From: Sjoerd Simons To: Marcel Holtmann Cc: "Gustavo F. Padovan" , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Drake , Larry Finger Date: Thu, 30 Jul 2015 14:12:42 +0200 In-Reply-To: <734FAB01-9120-43F7-A003-FD7822DFA2F8@holtmann.org> References: <1437144905-3482-1-git-send-email-sjoerd.simons@collabora.co.uk> <734FAB01-9120-43F7-A003-FD7822DFA2F8@holtmann.org> Organization: Collabora Ltd. Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3279 Lines: 78 On Thu, 2015-07-30 at 13:45 +0200, Marcel Holtmann wrote: > Hi Sjoerd, > > > Recognize Realtek devices which share wifi and bluetooth such as > > the > > rtl8723AU by vendor and interface. > > > > T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=480 MxCh= 0 > > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > > P: Vendor=0bda ProdID=0724 Rev= 2.00 > > S: Manufacturer=Realtek > > S: Product=802.11n WLAN Adapter > > S: SerialNumber=00e04c000001 > > C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=500mA > > A: FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01 > > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms > > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms > > I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms > > I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms > > I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms > > I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms > > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms > > I:* If#= 2 Alt= 0 #EPs= 4 Cls=ff(vend.) Sub=ff Prot=ff > > Driver=rtl8723au > > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=87(I) Atr=03(Int.) MxPS= 64 Ivl=500us > > > > Signed-off-by: Sjoerd Simons > > --- > > drivers/bluetooth/btusb.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > > index 93339a4..3324c91 100644 > > --- a/drivers/bluetooth/btusb.c > > +++ b/drivers/bluetooth/btusb.c > > @@ -149,6 +149,10 @@ static const struct usb_device_id > > btusb_table[] = { > > { USB_DEVICE(0x8087, 0x0a5a), > > .driver_info = BTUSB_INTEL_BOOT | BTUSB_BROKEN_ISOC }, > > > > + /* Realtek devices sharing Bluetooth and Wifi*/ > > + { USB_VENDOR_AND_INTERFACE_INFO(0x0bda, 0xe0, 0x01, 0x01), > > + .driver_info = BTUSB_REALTEK }, > > + > > is this still needed after I applied the generic USB_INTERFACE_INFO > patch? Noe as Daniel Drake mentioned in his submission, this patch is obsolete now that the USB_INTERFACE_INFO change has landed. -- Sjoerd Simons Collabora Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/