Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751857AbbG3MP2 (ORCPT ); Thu, 30 Jul 2015 08:15:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34006 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbbG3MP0 (ORCPT ); Thu, 30 Jul 2015 08:15:26 -0400 Date: Thu, 30 Jul 2015 14:15:24 +0200 From: Jiri Olsa To: Kan Liang Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org, ak@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC V7 6/7] perf,tools: per-event callgraph support Message-ID: <20150730121524.GM9606@krava.brq.redhat.com> References: <1438162936-59698-1-git-send-email-kan.liang@intel.com> <1438162936-59698-7-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438162936-59698-7-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1732 Lines: 52 On Wed, Jul 29, 2015 at 05:42:15AM -0400, Kan Liang wrote: SNIP > + > + /* User explicitly set per-event callgraph, clear the old setting and reset. */ > + if ((callgraph_buf != NULL) || (dump_size > 0)) { > + > + /* parse callgraph parameters */ > + if (callgraph_buf != NULL) { > + if (!strcmp(callgraph_buf, "no")) { > + param.enabled = false; > + param.record_mode = CALLCHAIN_NONE; > + } else { > + param.enabled = true; > + if (parse_callchain_record_opt(callgraph_buf, ¶m)) { > + pr_err("per-event callgraph setting for %s failed. " > + "Apply callgraph global setting for it\n", > + evsel->name); > + return; > + } > + } > + } > + if (dump_size > 0) > + param.dump_size = dump_size; > + > + /* If global callgraph set, clear it */ > + if (callchain_param.enabled) { > + perf_evsel__reset_sample_bit(evsel, CALLCHAIN); > + if (callchain_param.record_mode == CALLCHAIN_LBR) { > + perf_evsel__reset_sample_bit(evsel, BRANCH_STACK); > + attr->branch_sample_type &= ~(PERF_SAMPLE_BRANCH_USER | > + PERF_SAMPLE_BRANCH_CALL_STACK); > + } > + if (callchain_param.record_mode == CALLCHAIN_DWARF) { > + perf_evsel__reset_sample_bit(evsel, REGS_USER); > + perf_evsel__reset_sample_bit(evsel, STACK_USER); > + } > + } please put code above into perf_evsel__reset_callgraph ans place it close to perf_evsel__config_callgraph ;-) other than that the change looks ok to me now thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/