Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269AbbG3MSs (ORCPT ); Thu, 30 Jul 2015 08:18:48 -0400 Received: from mail.us.es ([193.147.175.20]:60530 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbbG3MSq (ORCPT ); Thu, 30 Jul 2015 08:18:46 -0400 X-Qmail-Scanner-Diagnostics: from 127.0.0.1 by antivirus3 (envelope-from , uid 501) with qmail-scanner-2.10 (clamdscan: 0.98.7/20742. spamassassin: 3.4.0. Clear:RC:1(127.0.0.1):SA:0(-102.2/7.5):. Processed in 1.811491 secs); 30 Jul 2015 12:18:45 -0000 X-Spam-ASN: AS12353 37.28.192.0/18 X-Envelope-From: pneira@us.es Date: Thu, 30 Jul 2015 14:24:33 +0200 From: Pablo Neira Ayuso To: Vaishali Thakkar Cc: Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: xtables: Add helper macro for xt_match boilerplate Message-ID: <20150730122433.GA5948@salvia> References: <20150726115737.GA14070@vaishali-Ideapad-Z570> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150726115737.GA14070@vaishali-Ideapad-Z570> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 18 On Sun, Jul 26, 2015 at 05:27:37PM +0530, Vaishali Thakkar wrote: > For simple modules that contain a single xt_match without any > additional setup code then ends up being a block of duplicated > boilerplate. This patch adds a new macro, module_xt_match(), > which replaces the module_init()/module_exit() registrations with > template functions. I prefer not to use this macro, we may need to add something to the module_init()/module_exit() path in the future to these netfilter extensions and then we'll have to revert the follow up conversions patches that you will likely send. Thanks anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/