Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747AbbG3NRm (ORCPT ); Thu, 30 Jul 2015 09:17:42 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:37454 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbbG3NR2 (ORCPT ); Thu, 30 Jul 2015 09:17:28 -0400 Date: Thu, 30 Jul 2015 14:17:23 +0100 From: Matt Fleming To: joeyli Cc: Borislav Petkov , "H. Peter Anvin" , "Lee, Chun-Yi" , Thomas Gleixner , Ingo Molnar , x86@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address Message-ID: <20150730131723.GG2725@codeblueprint.co.uk> References: <1438230757-30840-1-git-send-email-jlee@suse.com> <55B9D806.7030705@zytor.com> <20150730080323.GD8984@nazgul.tnic> <20150730101131.GB2725@codeblueprint.co.uk> <20150730110959.GJ15651@linux-rxt1.site> <20150730111819.GK15651@linux-rxt1.site> <20150730120916.GD2725@codeblueprint.co.uk> <20150730123116.GL15651@linux-rxt1.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150730123116.GL15651@linux-rxt1.site> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 25 On Thu, 30 Jul, at 08:31:16PM, joeyli wrote: > > I think hibernate overwrite it. We absolutely must get a more detailed answer before going any further. Simply put, if we're remapping the EFI regions into the virtual address space and calling SetVirtualAddressMap() on hibernate resume there is no reason that anyone should be using the old mappings. And since you've demonstrated that we *are* using the old mappings, we've likely got a bug somewhere that we need to get a handle on before we paper over the issue. Where exactly is the old mapping address being used? Is it that efi.systab->runtime->get_variable is incorrect? If you could paste the disassembled output where the page fault occurs, that would be helpful. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/