Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287AbbG3NwS (ORCPT ); Thu, 30 Jul 2015 09:52:18 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:60214 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753246AbbG3NwQ (ORCPT ); Thu, 30 Jul 2015 09:52:16 -0400 Date: Thu, 30 Jul 2015 21:52:10 +0800 From: Herbert Xu To: Dan Streetman Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: nx - don't err if compressed output > input Message-ID: <20150730135210.GA17690@gondor.apana.org.au> References: <1438213329-6884-1-git-send-email-ddstreet@ieee.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438213329-6884-1-git-send-email-ddstreet@ieee.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 22 On Wed, Jul 29, 2015 at 07:42:09PM -0400, Dan Streetman wrote: > Return success instead of error if compression succeeds but the output is > larger than the input. > > It's unlikely that the caller will use the compressed data since it's > larger than the original uncompressed data, but there was no error and > returning an error code is incorrect. Further, for testing small input > buffers, the output is likely to be larger than the input and success > needs to be returned to verify the test. > > Signed-off-by: Dan Streetman Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/