Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752965AbbG3OFT (ORCPT ); Thu, 30 Jul 2015 10:05:19 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:43621 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbbG3OFR (ORCPT ); Thu, 30 Jul 2015 10:05:17 -0400 X-IronPort-AV: E=Sophos;i="5.15,577,1432598400"; d="scan'208";a="289343263" From: David Vrabel To: CC: David Vrabel , , Robin Holt , Nathan Zimmer , Mel Gorman Subject: [PATCHv1] mm: always initialize pages as reserved to fix memory hotplug Date: Thu, 30 Jul 2015 15:04:43 +0100 Message-ID: <1438265083-31208-1-git-send-email-david.vrabel@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 36 Commit 92923ca3aacef63c92dc297a75ad0c6dfe4eab37 (mm: meminit: only set page reserved in the memblock region) breaks memory hotplug because pages within newly added sections are not marked as reserved as required by the memory hotplug driver. If pages within an offline section are not reserved, the secton cannot be onlined. Re-add the SetPageReserved() call. Signed-off-by: David Vrabel Cc: Robin Holt Cc: Nathan Zimmer Cc: Mel Gorman --- mm/page_alloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index ef19f22..89492f6 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -842,6 +842,7 @@ static void __meminit __init_single_page(struct page *page, unsigned long pfn, init_page_count(page); page_mapcount_reset(page); page_cpupid_reset_last(page); + SetPageReserved(page); INIT_LIST_HEAD(&page->lru); #ifdef WANT_PAGE_VIRTUAL -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/