Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753873AbbG3Oeo (ORCPT ); Thu, 30 Jul 2015 10:34:44 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38221 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753800AbbG3Oel (ORCPT ); Thu, 30 Jul 2015 10:34:41 -0400 Date: Thu, 30 Jul 2015 15:34:37 +0100 From: Peter Griffin To: Michael Ira Krufky Cc: Joe Perches , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, LKML , srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, lee.jones@linaro.org, hugues.fruchet@st.com, linux-media , devicetree@vger.kernel.org Subject: Re: [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X tuner. Message-ID: <20150730143437.GB22196@griffinp-ThinkPad-X1-Carbon-2nd> References: <1435158670-7195-1-git-send-email-peter.griffin@linaro.org> <1435158670-7195-3-git-send-email-peter.griffin@linaro.org> <1435195057.9377.18.camel@perches.com> <20150722185811.2d718baa@recife.lan> <20150730094738.GD488@griffinp-ThinkPad-X1-Carbon-2nd> <1438250928.2677.10.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3731 Lines: 98 Hi Michael, On Thu, 30 Jul 2015, Michael Ira Krufky wrote: > On Thu, Jul 30, 2015 at 7:14 AM, Michael Ira Krufky wrote: > > On Thu, Jul 30, 2015 at 6:08 AM, Joe Perches wrote: > >> On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote: > >>> Hi Mauro / Joe, > >>> > >>> On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote: > >>> > >>> > Em Wed, 24 Jun 2015 18:17:37 -0700 > >>> > Joe Perches escreveu: > >>> > > >>> > > On Wed, 2015-06-24 at 16:11 +0100, Peter Griffin wrote: > >>> > > > This is used in conjunction with the STV0367 demodulator on > >>> > > > the STV0367-NIM-V1.0 NIM card which can be used with the STi > >>> > > > STB SoC's. > >>> > > > >>> > > Barely associated to this specific patch, but for > >>> > > dvb-pll.c, another thing that seems possible is to > >>> > > convert the struct dvb_pll_desc uses to const and > >>> > > change the "entries" fixed array size from 12 to [] > >>> > > > >>> > > It'd save a couple KB overall and remove ~5KB of data. > >>> > > > >>> > > $ size drivers/media/dvb-frontends/dvb-pll.o* > >>> > > text data bss dec hex filename > >>> > > 8520 1552 2120 12192 2fa0 drivers/media/dvb-frontends/dvb-pll.o.new > >>> > > 5624 6363 2120 14107 371b drivers/media/dvb-frontends/dvb-pll.o.old > >>> > > >>> > Peter, > >>> > > >>> > Please add this patch on the next patch series you submit. > >>> > >>> Ok will do, I've added this patch with a slightly updated commit message > >>> to my series. > >>> > >>> Joe - Can I add your signed-off-by? > >> > >> Signed-off-by: Joe Perches > > > > Reviewed-by: Michael Ira Krufky > > > > Joe, nice optimization - thanks for that. > > > > With regards to Peter's patch, is this a digital-only tuner, or is it > > a hybrid tuner? > > > > The 5th byte that you send to the THOMSON DTT7546X seems to resemble > > the 'auxiliary byte' that gets set in tuner-simple.c > > > > I'm not sure that dvb-pll is the right place for this tuner > > definition, if this is the case. Maybe this definition belongs in > > tuner-simple instead, if the pattern matches better there. > > > > Mauro, can we hold off on merging Peter's patch until we resolve this? > > This code block, specifically, I would rather not see added into dvb-pll: > > +static int dvb_pll_get_num_regs(struct dvb_pll_priv *priv) > +{ > + int num_regs = 4; > + > + if (strncmp(priv->pll_desc->name, "Thomson dtt7546x", 16) == 0) > + num_regs = 5; > + > + return num_regs; > +} > + > > tuner-simple provides an infrastructure that allows this tuner to be > added in a more elegant way without the need to add special cases to > otherwise generic code, as done in the above. > > I'm sorry, Peter. Can you take a look at tuner-simple and consider > sending a new patch? Yes sure. I wasn't actually aware that tuner-simple existed. From what I can see briefly looking at it, it does look a more suitable way of adding support for this tuner. The dtt7546x is a dual tuner in that it supports dvb-t and dvb-c, however I have only tested it with DVB-T as that is the only feed I have to my home office. As I have a V2 incorporating all of Mauro's changes ready to send, and I'm on holiday for 3 weeks from Friday, I will temporarily drop support for this tuner and NIM card in V2, and migrate over to the new driver when I return end of August. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/