Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbbG3Pu5 (ORCPT ); Thu, 30 Jul 2015 11:50:57 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:36343 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbbG3Pu4 (ORCPT ); Thu, 30 Jul 2015 11:50:56 -0400 Message-ID: <55BA47E0.9030003@ti.com> Date: Thu, 30 Jul 2015 11:50:56 -0400 From: Murali Karicheri Organization: Texas Instruments User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: , , , , Subject: Re: [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space References: <1437515651-20883-1-git-send-email-m-karicheri2@ti.com> In-Reply-To: <1437515651-20883-1-git-send-email-m-karicheri2@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 42 On 07/21/2015 05:54 PM, Murali Karicheri wrote: > Currently on Keystone SoCs, boot up log shows an unnecessary boot > noise as follows:- > > [ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space > > Keystone uses older version of designware h/w that doesn't have ATU > support. So va_cfg0_base and va_cfg1_base are already set up in > ks_dw_pcie_host_init() before calling dw_pcie_host_init() and > they point to the remote config space address va (both same for Keystone). > So add a check to avoid this boot noise on Keystone. > > Signed-off-by: Murali Karicheri > --- > - Resend with "PCI: designware" prefix in subject > drivers/pci/host/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 69486be..b48b8a2 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp) > addrp = of_get_address(np, index, NULL, NULL); > pp->cfg0_mod_base = of_read_number(addrp, ns); > pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size; > - } else { > + } else if (!pp->va_cfg0_base) { > dev_err(pp->dev, "missing *config* reg space\n"); > } > > A gentle ping to review and apply this to pci next. -- Murali Karicheri Linux Kernel, Keystone -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/