Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754061AbbG3QXj (ORCPT ); Thu, 30 Jul 2015 12:23:39 -0400 Received: from mga09.intel.com ([134.134.136.24]:55035 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbbG3QXh (ORCPT ); Thu, 30 Jul 2015 12:23:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,577,1432623600"; d="scan'208";a="758530202" Message-ID: <1438273402.11322.17.camel@intel.com> Subject: Re: [RFC PATCH 07/16] efi: Public the function of transferring EFI status to kernel error From: Matt Fleming To: "Lee, Chun-Yi" CC: , , , "Rafael J. Wysocki" , "Matthew Garrett" , Len Brown , Pavel Machek , Josh Boyer , "Vojtech Pavlik" , Jiri Kosina , "H. Peter Anvin" , "Lee, Chun-Yi" Date: Thu, 30 Jul 2015 17:23:22 +0100 In-Reply-To: <1437056730-15247-8-git-send-email-jlee@suse.com> References: <1437056730-15247-1-git-send-email-jlee@suse.com> <1437056730-15247-8-git-send-email-jlee@suse.com> Organization: Intel Corporation (UK) Ltd. - Registered No. 1134945 - Pipers Way, Swindon SN3 1RJ Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [163.33.239.182] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 792 Lines: 19 On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > Moved the function of transferring EFI status to kernel error for > later used by EFI stub. > > Signed-off-by: Lee, Chun-Yi > --- > drivers/firmware/efi/vars.c | 33 --------------------------------- > include/linux/efi.h | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+), 33 deletions(-) The patch contents are fine but the title could do with some work, "public" isn't a verb. I think "Make efi_status_to_err() public" would be fine. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/