Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbbG3QdK (ORCPT ); Thu, 30 Jul 2015 12:33:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48266 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbbG3QdI (ORCPT ); Thu, 30 Jul 2015 12:33:08 -0400 Date: Thu, 30 Jul 2015 09:33:07 -0700 From: Greg Kroah-Hartman To: David Herrmann , Shuah Khan Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Gortmaker , Daniel Mack , Djalal Harouni Subject: Re: [PATCH] kdbus/samples: skip on CROSS_COMPILE Message-ID: <20150730163307.GA20048@kroah.com> References: <1438272805-19029-1-git-send-email-dh.herrmann@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438272805-19029-1-git-send-email-dh.herrmann@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 45 On Thu, Jul 30, 2015 at 06:13:25PM +0200, David Herrmann wrote: > Apparently we cannot rely on up-to-date kernel headers to be available > when cross-compiling, not even for HOSTCC. That's sad, but it's how it > is. Skip samples on cross-compiles as suggested by Paul, so allmodconfig > runs smoothly again. > > Tested-by: Paul Gortmaker > Signed-off-by: David Herrmann > --- > samples/kdbus/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/samples/kdbus/Makefile b/samples/kdbus/Makefile > index 137f842..dbd9de8 100644 > --- a/samples/kdbus/Makefile > +++ b/samples/kdbus/Makefile > @@ -1,9 +1,13 @@ > # kbuild trick to avoid linker error. Can be omitted if a module is built. > obj- := dummy.o > > +ifndef CROSS_COMPILE This really feels like the wrong solution. > + > hostprogs-$(CONFIG_SAMPLE_KDBUS) += kdbus-workers > > always := $(hostprogs-y) > > HOSTCFLAGS_kdbus-workers.o += -I$(objtree)/usr/include > HOSTLOADLIBES_kdbus-workers := -lrt > + > +endif Shuah, how should we fix this "properly"? How is this resolved for the kernel test scripts, it should have the same issue that the samples do. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/