Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753749AbbG3QnD (ORCPT ); Thu, 30 Jul 2015 12:43:03 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:36498 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753128AbbG3QnB (ORCPT ); Thu, 30 Jul 2015 12:43:01 -0400 Message-ID: <55BA5398.7020601@gmail.com> Date: Thu, 30 Jul 2015 09:40:56 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Nathan Sullivan CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume References: <1438269348-8725-1-git-send-email-nathan.sullivan@ni.com> In-Reply-To: <1438269348-8725-1-git-send-email-nathan.sullivan@ni.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1912 Lines: 63 On 30/07/15 08:15, Nathan Sullivan wrote: > The ksz9031 has a behavior where it will clear the interrupt enable bits > when leaving power down. To work around this, make sure the interrupt > bits are in the state they are expected to be when resuming. > > Signed-off-by: Nathan Sullivan Reviewed-by: Florian Fainelli > --- > > Changes for V2: Actually make sure it compiles this time. > > --- > drivers/net/phy/micrel.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 499185e..9774582 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -447,6 +447,22 @@ static int ksz9031_center_flp_timing(struct phy_device *phydev) > return genphy_restart_aneg(phydev); > } > > +static int ksz9031_resume(struct phy_device *phydev) > +{ > + int result; > + > + result = genphy_resume(phydev); > + > + if (result) > + return result; > + > + /* This phy will reset interrupt enables when leaving power down */ > + if (PHY_INTERRUPT_ENABLED & phydev->interrupts) > + result = kszphy_config_intr(phydev); > + > + return result; > +} > + > static int ksz9031_config_init(struct phy_device *phydev) > { > const struct device *dev = &phydev->dev; > @@ -776,7 +792,7 @@ static struct phy_driver ksphy_driver[] = { > .ack_interrupt = kszphy_ack_interrupt, > .config_intr = kszphy_config_intr, > .suspend = genphy_suspend, > - .resume = genphy_resume, > + .resume = ksz9031_resume, > .driver = { .owner = THIS_MODULE, }, > }, { > .phy_id = PHY_ID_KSZ8873MLL, > -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/