Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755401AbbG3RXn (ORCPT ); Thu, 30 Jul 2015 13:23:43 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32844 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910AbbG3RXl (ORCPT ); Thu, 30 Jul 2015 13:23:41 -0400 To: Tomas Winkler Cc: James Bottomley , Christoph Hellwig , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Gilbert Subject: Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check From: "Martin K. Petersen" Organization: Oracle Corporation References: <1438091666-18113-1-git-send-email-tomas.winkler@intel.com> <1438091666-18113-5-git-send-email-tomas.winkler@intel.com> Date: Thu, 30 Jul 2015 13:23:32 -0400 In-Reply-To: <1438091666-18113-5-git-send-email-tomas.winkler@intel.com> (Tomas Winkler's message of "Tue, 28 Jul 2015 16:54:24 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 15 >>>>> "Tomas" == Tomas Winkler writes: Tomas> The function should never be called with cmnd NULL so put a fat Tomas> WARN there. Fix also smatch wraning: schedule_resp() warn: Tomas> variable dereferenced before check 'cmnd' Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/