Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753650AbbG3Spj (ORCPT ); Thu, 30 Jul 2015 14:45:39 -0400 Received: from mga01.intel.com ([192.55.52.88]:38041 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbbG3Spi (ORCPT ); Thu, 30 Jul 2015 14:45:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,578,1432623600"; d="scan'208";a="739032972" Date: Thu, 30 Jul 2015 11:45:34 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Peter Zijlstra cc: Vikas Shivappa , linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, matt.fleming@intel.com, will.auld@intel.com, glenn.p.williamson@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 9/9] x86/intel_rdt: Intel haswell Cache Allocation enumeration In-Reply-To: <20150729163628.GZ25159@twins.programming.kicks-ass.net> Message-ID: References: <1435789270-27010-1-git-send-email-vikas.shivappa@linux.intel.com> <1435789270-27010-10-git-send-email-vikas.shivappa@linux.intel.com> <20150729163628.GZ25159@twins.programming.kicks-ass.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 789 Lines: 29 On Wed, 29 Jul 2015, Peter Zijlstra wrote: > On Wed, Jul 01, 2015 at 03:21:10PM -0700, Vikas Shivappa wrote: >> + /* >> + * Probe test for Haswell CPUs. > > Maybe elucidate and say: Probe for Haswell Server parts. > > As said before, probe and test mean roughly the same thing, and the > model test below makes the general 'Haswell CPUs' false, because there's > at least 3 other models that are also Haswell. Will fix, Thanks, Vikas > >> + */ >> + if (c->x86 == 0x6 && c->x86_model == 0x3f) >> + return cache_alloc_hsw_probe(); >> + > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/