Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbbG3T35 (ORCPT ); Thu, 30 Jul 2015 15:29:57 -0400 Received: from arrakis.dune.hu ([78.24.191.176]:55771 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbbG3T34 (ORCPT ); Thu, 30 Jul 2015 15:29:56 -0400 MIME-Version: 1.0 In-Reply-To: <1438167874-1305-1-git-send-email-leilk.liu@mediatek.com> References: <1438167874-1305-1-git-send-email-leilk.liu@mediatek.com> From: Jonas Gorski Date: Thu, 30 Jul 2015 21:29:28 +0200 Message-ID: Subject: Re: [PATCH v4 0/3] Add Mediatek SPI bus driver To: Leilk Liu Cc: Mark Brown , Mark Rutland , Matthias Brugger , Sascha Hauer , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 620 Lines: 19 Hi, On Wed, Jul 29, 2015 at 1:04 PM, Leilk Liu wrote: > Change in v4: > 1. fix Mark Brown review comment. You should say what you actually fixed/changed, not just that you changed something. Also the individual patches should contain changelogs as well (under the tear-off line (--), so one knows if something was changed between versions. Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/