Message-ID: <1438286389.2993.365.camel@freescale.com>
Subject: Re: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the
 FSL QorIQ DPAA FMan
From: Scott Wood <scottwood@freescale.com>
To: <igal.liberman@freescale.com>
CC: <devicetree@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
        <madalin.bucur@freescale.com>, <linux-kernel@vger.kernel.org>
Date: Thu, 30 Jul 2015 14:59:49 -0500
In-Reply-To: <1438230764-10951-1-git-send-email-igal.liberman@freescale.com>
References: <1438230764-10951-1-git-send-email-igal.liberman@freescale.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2015 19:59:54.1813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1473
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 812
Lines: 23

On Thu, 2015-07-30 at 07:32 +0300, Igal.Liberman wrote:
> +fman0:  fman@400000{
> +     #address-cells = <1>;
> +     #size-cells = <1>;
> +     cell-index = <0>;
> +     compatible = "fsl,fman";
> +     ranges = <0 0x400000 0x100000>;
> +     reg = <0x400000 0x100000>;
> +     interrupts = <96 2 0 0>, <16 2 1 1>;
> +     clocks = <&clockgen 3 0>;
> +     clock-names = "fm0clk";

clock-names should be "fmanclk" as per the binding.  And why would you want 
the driver to have to encode the fman index into the name in order to look 
the clock up by name?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/