Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbbG3Uos (ORCPT ); Thu, 30 Jul 2015 16:44:48 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36837 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751391AbbG3Uop (ORCPT ); Thu, 30 Jul 2015 16:44:45 -0400 MIME-Version: 1.0 In-Reply-To: <20150730204249.GN30479@wotan.suse.de> References: <20150730165155.33962.64121.stgit@dwillia2-desk3.amr.corp.intel.com> <20150730165345.33962.80299.stgit@dwillia2-desk3.amr.corp.intel.com> <20150730204249.GN30479@wotan.suse.de> Date: Thu, 30 Jul 2015 13:44:44 -0700 Message-ID: Subject: Re: [PATCH v3 01/24] mm: enhance region_is_ram() to region_intersects() From: Dan Williams To: "Luis R. Rodriguez" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-arch@vger.kernel.org, "Kani, Toshimitsu" , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" , Russell King , Christoph Hellwig , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 30 On Thu, Jul 30, 2015 at 1:42 PM, Luis R. Rodriguez wrote: > On Thu, Jul 30, 2015 at 12:53:45PM -0400, Dan Williams wrote: >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 2e872f92dbac..84b05ebedb2d 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -369,7 +369,14 @@ static inline int put_page_unless_one(struct page *page) >> } >> >> extern int page_is_ram(unsigned long pfn); >> -extern int region_is_ram(resource_size_t phys_addr, unsigned long size); >> + >> +enum { >> + REGION_INTERSECTS, >> + REGION_DISJOINT, >> + REGION_MIXED, >> +}; >> + > > Can you Kdoc'ify this? Part of the reason for the enum request was this > could be then documented really well. The helper is documented but here > you can go into more detail about each region intersection. Given region_intersects() has its own kdoc I'd probably just say "See region_intersects() for details". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/