Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbbG3Wyn (ORCPT ); Thu, 30 Jul 2015 18:54:43 -0400 Received: from www.linutronix.de ([62.245.132.108]:48983 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbbG3Wyl (ORCPT ); Thu, 30 Jul 2015 18:54:41 -0400 From: John Ogness To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman Cc: Tony Lindgren Cc: Peter Hurley Cc: Sebastian Andrzej Siewior Cc: linux-omap@vger.kernel.org Cc: nsekhar@ti.com Cc: tony@atomide.com Cc: nm@ti.com Cc: linux-serial@vger.kernel.org Subject: [PATCH 2/3] serial: 8250: move rx_running out of the bitfield Date: Fri, 31 Jul 2015 00:54:35 +0200 Message-ID: <87fv452r4k.fsf@linutronix.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 29 That bitfield is modified by read + or + write operation. If someone sets any of the other two bits it might render the lock useless. Signed-off-by: John Ogness Signed-off-by: Sebastian Andrzej Siewior --- drivers/tty/serial/8250/8250.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h index c43f74c..78f5e3a 100644 --- a/drivers/tty/serial/8250/8250.h +++ b/drivers/tty/serial/8250/8250.h @@ -44,7 +44,7 @@ struct uart_8250_dma { unsigned char tx_running:1; unsigned char tx_err: 1; - unsigned char rx_running:1; + unsigned char rx_running; }; struct old_serial_port { -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/