Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752373AbbG3XRL (ORCPT ); Thu, 30 Jul 2015 19:17:11 -0400 Received: from mail-yk0-f176.google.com ([209.85.160.176]:33227 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbbG3XRJ (ORCPT ); Thu, 30 Jul 2015 19:17:09 -0400 MIME-Version: 1.0 In-Reply-To: <20150730184010.GC11177@pox.localdomain> References: <1438279963-29563-1-git-send-email-joestringer@nicira.com> <1438279963-29563-2-git-send-email-joestringer@nicira.com> <20150730184010.GC11177@pox.localdomain> From: Joe Stringer Date: Thu, 30 Jul 2015 16:16:49 -0700 Message-ID: Subject: Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive() To: Thomas Graf Cc: Linux Netdev List , Linux Kernel , Pablo Neira Ayuso , Patrick McHardy , Justin Pettit , Pravin Shelar , Andy Zhou , Jesse Gross , Florian Westphal , Hannes Sowa Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1638 Lines: 39 On 30 July 2015 at 11:40, Thomas Graf wrote: > On 07/30/15 at 11:12am, Joe Stringer wrote: >> Signed-off-by: Joe Stringer > > Can you write a few lines on why this is needed? I have flows which > use the mark to communicate with netfilter through internal ports. The problem I was seeing is when packets come from a different namespace on the localhost, they still have conntrack data associated. This doesn't make sense, so the intention is to perform nf_reset(). However, it seems like we should actually be doing a bit more - at least the skb_dst_drop() and perhaps some of the other stuff in skb_scrub_packet(). Do you want to retain the mark when transitioning between namespaces? Perhaps something like the below incremental would be sufficient: diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index 8a63df6..82844e6 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -475,7 +475,9 @@ void ovs_vport_receive(struct vport *vport, struct sk_buff *skb, struct sw_flow_key key; int error; - if (!skb->sk || (sock_net(skb->sk) != read_pnet(&vport->dp->net))) + if (!skb->sk) + skb_scrub_packet(skb, false); + else if (sock_net(skb->sk) != read_pnet(&vport->dp->net)) skb_scrub_packet(skb, true); stats = this_cpu_ptr(vport->percpu_stats); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/