Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbbG3XYZ (ORCPT ); Thu, 30 Jul 2015 19:24:25 -0400 Received: from mail-qg0-f48.google.com ([209.85.192.48]:34070 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbbG3XYY (ORCPT ); Thu, 30 Jul 2015 19:24:24 -0400 Message-ID: <55BAB226.6090706@hurleysoftware.com> Date: Thu, 30 Jul 2015 19:24:22 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: John Ogness , linux-kernel@vger.kernel.org CC: Greg Kroah-Hartman , Tony Lindgren , Sebastian Andrzej Siewior , linux-omap@vger.kernel.org, nsekhar@ti.com, nm@ti.com, linux-serial@vger.kernel.org Subject: Re: [PATCH 2/3] serial: 8250: move rx_running out of the bitfield References: <87fv452r4k.fsf@linutronix.de> In-Reply-To: <87fv452r4k.fsf@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1149 Lines: 36 On 07/30/2015 06:54 PM, John Ogness wrote: > That bitfield is modified by read + or + write operation. If someone > sets any of the other two bits it might render the lock useless. Good catch. Let's just make all of the fields not bitfield though. Regards, Peter Hurley > Signed-off-by: John Ogness > Signed-off-by: Sebastian Andrzej Siewior > --- > drivers/tty/serial/8250/8250.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h > index c43f74c..78f5e3a 100644 > --- a/drivers/tty/serial/8250/8250.h > +++ b/drivers/tty/serial/8250/8250.h > @@ -44,7 +44,7 @@ struct uart_8250_dma { > > unsigned char tx_running:1; > unsigned char tx_err: 1; > - unsigned char rx_running:1; > + unsigned char rx_running; > }; > > struct old_serial_port { > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/