Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751836AbbGaCDX (ORCPT ); Thu, 30 Jul 2015 22:03:23 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:33266 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbbGaCDV (ORCPT ); Thu, 30 Jul 2015 22:03:21 -0400 MIME-Version: 1.0 In-Reply-To: <20150730122433.GA5948@salvia> References: <20150726115737.GA14070@vaishali-Ideapad-Z570> <20150730122433.GA5948@salvia> Date: Fri, 31 Jul 2015 07:33:20 +0530 Message-ID: Subject: Re: [PATCH] netfilter: xtables: Add helper macro for xt_match boilerplate From: Vaishali Thakkar To: Pablo Neira Ayuso Cc: Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 28 On Thu, Jul 30, 2015 at 5:54 PM, Pablo Neira Ayuso wrote: > On Sun, Jul 26, 2015 at 05:27:37PM +0530, Vaishali Thakkar wrote: >> For simple modules that contain a single xt_match without any >> additional setup code then ends up being a block of duplicated >> boilerplate. This patch adds a new macro, module_xt_match(), >> which replaces the module_init()/module_exit() registrations with >> template functions. > > I prefer not to use this macro, we may need to add something to the > module_init()/module_exit() path in the future to these netfilter > extensions and then we'll have to revert the follow up conversions > patches that you will likely send. Ok. This makes sense. I think in that case you can drop the patch. Thank You. > Thanks anyway. -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/